Problem/Motivation

%Since twig/twig 3.12: The "tag" constructor argument of the "Drupal\\Core\\Template\\TwigNodeTrans" class is deprecated and ignored%

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

Introduced terminology

API changes

Data model changes

Release notes snippet

Issue fork drupal-3477374

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

longwave created an issue. See original summary.

finnsky made their first commit to this issue’s fork.

finnsky’s picture

finnsky commented
Status: Active » Needs review

finnsky opened merge request !9667

bbrala’s picture

bbrala
Location Netherlands
commented
Status: Needs review » Reviewed & tested by the community

Changes look good.

  1. Checked if there is other places this parent class is used. SDC has some, but doesn't use that variable.
  2. Tests are green (nightwatch was being silly)

Don't see anything wrong here. Since this variable is useless anyways (see deprecation message) there is little risk.

  • catch committed 8b7350e2 on 10.3.x 
    Issue #3477374 by finnsky, longwave, bbrala: Fix "The "tag" constructor...

  • catch committed 193eca89 on 10.4.x 
    Issue #3477374 by finnsky, longwave, bbrala: Fix "The "tag" constructor...

  • catch committed d58d513d on 11.0.x 
    Issue #3477374 by finnsky, longwave, bbrala: Fix "The "tag" constructor...
catch’s picture

catch
he/him
Primary language English
commented
Version: 11.x-dev » 10.3.x-dev
Status: Reviewed & tested by the community » Fixed

Yep agreed this looks straightforward.

Committed/pushed to 11.x and cherry-picked back through to 10.3.x, thanks!

  • catch committed cec21638 on 11.x 
    Issue #3477374 by finnsky, longwave, bbrala: Fix "The "tag" constructor...

catch closed merge request !9667

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.