Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

sunil jolapara created an issue. See original summary.

sunil jolapara’s picture

Status: Needs work » Needs review
avpaderno’s picture

Version: 2.0.1 » 2.0.x-dev
Status: Needs review » Needs work
Issue tags: +Needs issue summary update

The issue summary for PHP_CodeSniffer issues should always show the report given from PHP_CodeSniffer and the arguments passed to phpcs.

Furthermore, since GitLab CI is now enabled for all the projects, GitLab CI should be used to get PHP_CodeSniffer errors/warnings.

cleavinjosh’s picture

Version: 2.0.x-dev » 8.x-1.x-dev
Assigned: » cleavinjosh
Issue summary: View changes
Status: Needs work » Needs review
Issue tags: -Needs issue summary update
cleavinjosh’s picture

Status: Needs review » Needs work

Hi @sunil jolapara,

Thank you for providing an MR. I applied MR!1, it was applied smoothly and fixed most of the phpcs issues.

These are the remaining issues after I ran phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml:

➜  contrib git:(main) ✗ phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml ckeditor_tweetthis

FILE: /Users/interns/Demo-site/drupal_11_test/install-dir/drupal_11_test_site/web/modules/contrib/ckeditor_tweetthis/ckeditor_tweetthis.info.yml
------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
------------------------------------------------------------------------------------------------------------------------------------------------
 9 | WARNING | All dependencies must be prefixed with the project name, for example "drupal:"
------------------------------------------------------------------------------------------------------------------------------------------------


FILE: /Users/interns/Demo-site/drupal_11_test/install-dir/drupal_11_test_site/web/modules/contrib/ckeditor_tweetthis/src/Plugin/CKEditorPlugin/TweetThis.php
------------------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
------------------------------------------------------------------------------------------------------------------------------------------------------------
 54 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
------------------------------------------------------------------------------------------------------------------------------------------------------------

Time: 182ms; Memory: 10MB

➜  contrib git:(main) ✗

cleavinjosh’s picture

cleavinjosh’s picture

cleavinjosh changed the visibility of the branch 3477024-phpcs-issues to hidden.

cleavinjosh’s picture

Assigned: cleavinjosh » Unassigned
Status: Needs work » Needs review

Hi,

Please review, check and advise on MR!1. Thank you.

avpaderno’s picture

Version: 8.x-1.x-dev » 2.0.x-dev
Status: Needs review » Needs work
Issue tags: +Needs issue summary update

The issue summary must still be updated. The supported branch is 2.x.

cleavinjosh’s picture

Assigned: Unassigned » cleavinjosh

cleavinjosh changed the visibility of the branch 3477024-phpcs-issues to active.

cleavinjosh’s picture

Issue summary: View changes
Issue tags: -Needs issue summary update

avpaderno changed the visibility of the branch 3477024-fix-the-phpcodesniffer-issues to hidden.

cleavinjosh’s picture

cleavinjosh’s picture

Assigned: cleavinjosh » Unassigned
Status: Needs work » Needs review

Hi @avpaderno,

Please review, check, and advise on MR!2. Thank you.

avpaderno’s picture

Issue summary: View changes

anjalisudhi’s picture

Version: 2.0.x-dev » 11.1.x-dev
Status: Needs review » Fixed

This issue has been resolved. A new release with the fix has been published.

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

anjalisudhi’s picture

Status: Fixed » Closed (fixed)