Closed (fixed)
Project:
CK Editor Tweetthis
Version:
11.1.x-dev
Component:
Code
Priority:
Minor
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
26 Sep 2024 at 13:09 UTC
Updated:
24 Nov 2025 at 06:46 UTC
Jump to comment: Most recent
Comments
Comment #3
sunil jolapara commentedComment #4
avpadernoThe issue summary for PHP_CodeSniffer issues should always show the report given from PHP_CodeSniffer and the arguments passed to
phpcs.Furthermore, since GitLab CI is now enabled for all the projects, GitLab CI should be used to get PHP_CodeSniffer errors/warnings.
Comment #5
cleavinjosh commentedComment #6
cleavinjosh commentedHi @sunil jolapara,
Thank you for providing an MR. I applied MR!1, it was applied smoothly and fixed most of the phpcs issues.
These are the remaining issues after I ran
phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml:Comment #8
cleavinjosh commentedList of phpcs issues found by Gitlab CI before the changes.
Comment #9
cleavinjosh commentedNo more phpcs issues found.
Comment #11
cleavinjosh commentedHi,
Please review, check and advise on MR!1. Thank you.
Comment #12
avpadernoThe issue summary must still be updated. The supported branch is 2.x.
Comment #13
cleavinjosh commentedComment #15
cleavinjosh commentedComment #17
cleavinjosh commentedNo more phpcs issues found.
Comment #18
cleavinjosh commentedHi @avpaderno,
Please review, check, and advise on MR!2. Thank you.
Comment #19
avpadernoComment #22
anjalisudhi commentedThis issue has been resolved. A new release with the fix has been published.
Comment #24
anjalisudhi commented