Using semantically correct HTML should not be a per-case consideration. One might argue if a screenreader user would ever want to rotate an image - but why hindering that task?

  • Replace empty href link with button
  • Move given title attribute to button text
  • Add class to allow CSS tweaks (thus making it possible to place the UTF8 character ↻ in a ::before element)
  • Add feedback
  • Change wording in settings form (decision is about the rotate function, not the icon)
CommentFileSizeAuthor
#7 simple_image_rotate-3476687-replace-link-with-button.patch5.1 KBtobiasb

Issue fork simple_image_rotate-3476687

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

tobiasb created an issue. See original summary.

tobiasb opened merge request !6

hexabinaer’s picture

hexabinaer
Location Berlin, Germany
commented
Issue summary: View changes
hexabinaer’s picture

hexabinaer
Location Berlin, Germany
commented
Issue summary: View changes
hexabinaer’s picture

hexabinaer
Location Berlin, Germany
commented
Issue summary: View changes
tobiasb’s picture

tobiasb
Primary language German
Location Berlin
commented
Issue tags: -a11y +Accessibility
tobiasb’s picture

tobiasb
Primary language German
Location Berlin
commented
Assigned: tobiasb » Unassigned
Status: Active » Needs review
StatusFileSize
new simple_image_rotate-3476687-replace-link-with-button.patch5.1 KB

Static patch file for https://www.drupal.org/project/openculturas.

mrshowerman’s picture

mrshowerman
Location Munich
commented
Status: Needs review » Needs work

+1 for this change.

There is a typo in the settings form description (missing comma), and the text could be optimised a little:

If checked, a button to rotate the image will appear next to each image.

atul_ghate made their first commit to this issue’s fork.

atul_ghate’s picture

atul_ghate commented
Status: Needs work » Needs review
mrshowerman’s picture

mrshowerman
Location Munich
commented
Status: Needs review » Reviewed & tested by the community

LGTM.

kohanserhiy made their first commit to this issue’s fork.

kohanserhiy opened merge request !7

tobiasb changed the visibility of the branch 3476687-alternative_button to hidden.

  • afagioli committed a0e19359 on 2.3.x 
    Refactor image rotate: replace link with button (#3476687), add...
afagioli’s picture

afagioli
Location Rome
commented

https://www.drupal.org/project/simple_image_rotate/releases/2.3.0-alpha2

afagioli’s picture

afagioli
Location Rome
commented
Status: Reviewed & tested by the community » Fixed

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

tobiasb closed merge request !6

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.