Fix the issues reported by PHP_CodeSniffer

Hi @sunil jolapara,

Thank you for providing an MR. I applied MR!3, it was applied smoothly and fixed the phpcs issues.

➜  media_contextual_crop_iwc_adapter git:(1.0.x) curl https://git.drupalcode.org/project/media_contextual_crop_iwc_adapter/-/merge_requests/3.diff | patch -p1
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100 10203    0 10203    0     0  26520      0 --:--:-- --:--:-- --:--:-- 26501
patching file .gitlab-ci.yml
patching file composer.json
patching file media_contextual_crop_iwc_adapter.info.yml
patching file media_contextual_crop_iwc_adapter.module
patching file src/Plugin/MediaContextualCrop/ImageWidgetCrop.php
➜  media_contextual_crop_iwc_adapter git:(1.0.x) ✗ ..
➜  contrib git:(main) ✗ phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml media_contextual_crop_iwc_adapter
➜  contrib git:(main) ✗

Thank you.

The issue summary for PHP_CodeSniffer issues should always show the report given from PHP_CodeSniffer and the arguments passed to phpcs.

Furthermore, since GitLab CI is now enabled for all the projects, GitLab CI should be used to get PHP_CodeSniffer errors/warnings.

Can you make the MR for the 2.x branch ?

the 1.x branch are minimaly maintained now

thanks

The issue summary still needs to be updated, since it should link to the GitLab CI report.

@drdam May the 2.0.x branch be set as the default one?

It's the case

Hi,

My apologies, there might have been some composer dependency resolution issues.

I am not sure how to proceed.

Please check and advise. Thank you.

Hi,

I have applied the latest MR!6 to the Media Contextual ImageWidgetCrop Adapter (2.0.x-dev) on my Drupal local setup, and confirmed all PHPCS errors have been fixed.

FILE: /Users/roberttabigue/Project/DrupalOrg/drupalorgissues/web/themes/contrib/media_contextual_crop_iwc_adapter/media_contextual_crop_iwc_adapter.module
----------------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------------------------------------------------------------------------------------------
 68 | ERROR | [x] Expected 1 space after IF keyword; 0 found
----------------------------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------------------------------------------------------------------------------------------

Time: 103ms; Memory: 10MB

I ran this command on the module:
phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml media_contextual_crop_iwc_adapter

Please see the attached file for reference.

I'm moving this now to "RTBC".

Thank you!

Thanks all

Released in 2.0.4