Problem/Motivation

phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml .

FILE: .../web/modules/custom/native_lazy_loading/native_lazy_loading.module
-----------------------------------------------------------------------------------------------------------------------
FOUND 10 ERRORS AFFECTING 10 LINES
-----------------------------------------------------------------------------------------------------------------------
1 | ERROR | [x] Missing file doc comment
21 | ERROR | [x] Expected 1 blank line after function; 2 found
48 | ERROR | [ ] Doc comment short description must be on a single line, further text should be a separate paragraph
87 | ERROR | [x] Data types in @var tags need to be fully namespaced
131 | ERROR | [ ] Missing short description in doc comment
132 | ERROR | [ ] Missing parameter comment
134 | ERROR | [ ] Description for the @return value is missing
136 | ERROR | [x] Namespaced classes/interfaces/traits should be referenced with use statements
150 | ERROR | [x] Namespaced classes/interfaces/traits should be referenced with use statements
163 | ERROR | [x] Namespaced classes/interfaces/traits should be referenced with use statements
-----------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 6 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-----------------------------------------------------------------------------------------------------------------------

FILE: .../web/modules/custom/native_lazy_loading/README.md
-----------------------------------------------------------------------------------
FOUND 0 ERRORS AND 9 WARNINGS AFFECTING 9 LINES
-----------------------------------------------------------------------------------
5 | WARNING | Line exceeds 80 characters; contains 95 characters
9 | WARNING | Line exceeds 80 characters; contains 296 characters
11 | WARNING | Line exceeds 80 characters; contains 272 characters
17 | WARNING | Line exceeds 80 characters; contains 198 characters
19 | WARNING | Line exceeds 80 characters; contains 118 characters
21 | WARNING | Line exceeds 80 characters; contains 82 characters
24 | WARNING | Line exceeds 80 characters; contains 122 characters
28 | WARNING | Line exceeds 80 characters; contains 181 characters
33 | WARNING | Line exceeds 80 characters; contains 371 characters
-----------------------------------------------------------------------------------

Steps to reproduce

phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml .

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Issue fork native_lazy_loading-3475328

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

alyaj2a created an issue. See original summary.

alyaj2a’s picture

alyaj2a commented
Assigned: Unassigned » alyaj2a

alyaj2a opened merge request !4

alyaj2a’s picture

alyaj2a commented
Status: Active » Needs review
cleavinjosh’s picture

cleavinjosh commented
Assigned: alyaj2a » Unassigned
Status: Needs review » Reviewed & tested by the community

Hi @alyaj2a,

Thank you for providing an MR. I applied MR!4, it was applied smoothly and fixed all the phpcs issues.

➜  native_lazy_loading git:(1.1.x) curl https://git.drupalcode.org/project/native_lazy_loading/-/merge_requests/4.diff | patch -p1
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100  7774    0  7774    0     0  10194      0 --:--:-- --:--:-- --:--:-- 10188
patching file README.md
patching file native_lazy_loading.module
➜  native_lazy_loading git:(1.1.x) ✗ ..
➜  contrib git:(main) ✗ phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml native_lazy_loading
➜  contrib git:(main) ✗

Thank you.

  • prudloff committed 7a1d013a on 1.1.x authored by alyaj2a 
    fix: #3475328 Coding Standard Issues

By: alyaj2a
By: cleavinjosh
prudloff’s picture

prudloff commented
Status: Reviewed & tested by the community » Fixed

I merged this because the changes are straightforward but this module is obsolete and not developed anymore.

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.