Problem/Motivation

When taking advantage of a number of new settings introduced in 3445280 the conditions are currently too strict that prevents them from applying to on-prem hosted WProofreader.

Steps to reproduce

  1. Use on prem WProofreader
  2. Remove various permissions for roles
  3. Observe changes do not take effect

Proposed resolution

Update condition to ensure it only affects the connection details and 'Default settings' and below are still evaluated.

Remaining tasks

* Community review

User interface changes

N/A

API changes

N/A

Data model changes

N/A

Issue fork ckeditor5_premium_features-3474841

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

alexj12 created an issue. See original summary.

alexj12 opened merge request !14

alexj12’s picture

alexj12 commented
Status: Active » Needs review

Just linking commit 539edcf2cfe124f4e046f553b16c85982498cd4f as I believe this shows that the lack of application of these settings to on-prem is an oversight rather than being purposeful, as the connection condition contains a return which has not been touched.

alexj12’s picture

alexj12 commented
Assigned: alexj12 » Unassigned
salmonek’s picture

salmonek commented
Status: Needs review » Reviewed & tested by the community

Hi @alexj12
Thank you for cathing this. Indeed it is an oversight, not design.

  • salmonek committed 0929d5a3 on 1.3.x authored by alexj12 
    Issue #3474841 by alexj12: Newer user settings don't apply to on-prem...
salmonek’s picture

salmonek commented
salmonek’s picture

salmonek commented
Status: Reviewed & tested by the community » Fixed

The fix has beeen released in version 1.3.2
Thank you @alexj12 for the contribution.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.