Problem/Motivation

On Drupal 10.3.x, PHP 8.3.x, an error is produced in image generation:

ArgumentCountError: Too few arguments to function Drupal\image\Controller\ImageStyleDownloadController::deliver(), 3 passed in web/modules/contrib/auto_retina/src/Controller/RetinaImageStyleDownloadController.php on line 73 and exactly 4 expected in Drupal\image\Controller\ImageStyleDownloadController->deliver() (line 111 of web/core/modules/image/src/Controller/ImageStyleDownloadController.php).

Steps to reproduce

Generate an auto-retina derivative image, then check the log.

Proposed resolution

Pass the correct number of arguments to Drupal\image\Controller\ImageStyleDownloadController->deliver().

Remaining tasks

Patch & review.

User interface changes

None.

API changes

None.

Data model changes

None.

Issue fork auto_retina-3474316

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

  • 2.x Comparechanges, plain diff MR !5
About issue forks

Comments

chrisolof created an issue. See original summary.

ananya.k’s picture

ananya.k commented
Assigned: Unassigned » ananya.k

thomas kaisuka made their first commit to this issue’s fork.

thomas kaisuka opened merge request !5

thomas kaisuka closed merge request !5

thomas kaisuka reopened merge request !5

chrisolof’s picture

chrisolof
he/him
Primary language English
commented
Status: Active » Needs work

Thanks DrupalHunk! The changes in 057961e40decefada8c9b92066e5a5ab66087511 (from MR5) appear to resolve this issue.

MR5 also currently introduces a .gitlab‎-ci.yml‎ file that seems to be a start at running automated testing / linting / building (of which we have none yet).

I feel this isn't the right issue to bring in a .gitlab‎-ci.yml file, unless it also brings in a test confirming the fix here. I've opened #3474718: Automate manual tests, which I think would be a good spot to bring in a .gitlab‎-ci.yml file.

ananya.k’s picture

ananya.k commented
Assigned: ananya.k » Unassigned
thomas kaisuka’s picture

thomas kaisuka commented

@chrisolof .gitlab‎-ci.yml brings in a test confirming the fix here. But better can be done for the other pending manual tests.

aklump’s picture

aklump commented
Assigned: Unassigned » aklump

  • aklump committed ba201a0c on 2.x 
    Issue #3474316 by thomas kaisuka, chrisolof, ananya.k, aklump:...
aklump’s picture

aklump commented
Status: Needs work » Fixed

Has been fixed, and will appear in 2.0.3. Thank you to everyone who helped on this: @thomas kaisuka, @chrisolof, @ananya.k!

aklump’s picture

aklump commented
Status: Fixed » Closed (fixed)