Problem/Motivation

Getting below error when I was trying to install the module with Drupal 11.

The website encountered an unexpected error. Try again later.
Too few arguments to function Drupal\Core\Form\ConfigFormBase::__construct(), 1 passed in /var/www/html/web/modules/contrib/psa_oecd_publishing/src/Form/OecdPublishingSettingsForm.php on line 60 and exactly 2 expected

Steps to reproduce

Install module with Drupal 11 and go to configuration page of this module.

See the related change record.

CommentFileSizeAuthor
#14 OECD_after.mp47.95 MBatul_ghate
#4 Screenshot from 2024-09-13 14-35-08.png180.34 KBsourav_paul
#4 Screenshot from 2024-09-13 14-28-02.png520.96 KBsourav_paul
#4 Screenshot from 2024-09-13 14-30-15.png44.2 KBsourav_paul

Issue fork psa_oecd_publishing-3474073

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

anwar_max created an issue. See original summary.

sourav_paul’s picture

sourav_paul
Location Kolkata
commented
Assigned: Unassigned » sourav_paul

sourav_paul opened merge request !2

sourav_paul’s picture

sourav_paul
Location Kolkata
commented
Assigned: sourav_paul » Unassigned
Status: Active » Needs review
StatusFileSize
new Screenshot from 2024-09-13 14-30-15.png44.2 KB
new Screenshot from 2024-09-13 14-28-02.png520.96 KB
new Screenshot from 2024-09-13 14-35-08.png180.34 KB

I've checked the module code of 1.0.x-dev branch on D11.0.1.

This module is incompatible with drupal11.

I've made the module code compatible with D11.

please review...

attaching ss for reference:

Before: Only local images are allowed.

img

After:
img

liam morland’s picture

liam morland
Primary language English
Location Ontario, CA 🇨🇦
commented

Thanks for the patch. I don't think that $typedConfigManager should have the protected visibility indicator because it is declared as a property elsewhere.

liam morland’s picture

liam morland
Primary language English
Location Ontario, CA 🇨🇦
commented
Version: 1.0.x-dev » 1.1.x-dev
Issue summary: View changes
atul_ghate’s picture

atul_ghate commented

MR!2 is not applying as a patch for the 1.1.x branch. Please re-rolle the MR against 1.1.x

atul_ghate’s picture

atul_ghate commented
Status: Needs review » Needs work
liam morland’s picture

liam morland
Primary language English
Location Ontario, CA 🇨🇦
commented

I don't think commit 7bf5ec7 is needed, but the other commit needs to be fixed like I said in #5.

Please remove the changes to core_version_requirement; that will be done in #3434027: Automated Drupal 11 compatibility fixes for psa_oecd_publishing, which also needs to be rebased.

sourav_paul’s picture

sourav_paul
Location Kolkata
commented
Status: Needs work » Needs review
sourav_paul’s picture

sourav_paul
Location Kolkata
commented

@liam morland I've resolved your feedback, could you please review & merge the MR..

liam morland’s picture

liam morland
Primary language English
Location Ontario, CA 🇨🇦
commented
Status: Needs review » Needs work

Because of the changes in the testing infrastructure, we'll need to do the core_version_requirement changes here so that tests can run.

sourav_paul’s picture

sourav_paul
Location Kolkata
commented
Status: Needs work » Needs review
atul_ghate’s picture

atul_ghate commented
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new OECD_after.mp47.95 MB

I have reviewed and applied MR2. It resolved the mentioned issue, and we can now install this module on Drupal 11 without any errors. Changing the status to RTBC. See the attached video for reference.

sourav_paul’s picture

sourav_paul
Location Kolkata
commented

@lkmorlan if it is fully compatible with D11 & Tested.

Can you please make a new release for that?

liam morland’s picture

liam morland
Primary language English
Location Ontario, CA 🇨🇦
commented
Status: Reviewed & tested by the community » Needs review

When cleaning-up the commits, I made a minor change. Please test again.

liam morland’s picture

liam morland
Primary language English
Location Ontario, CA 🇨🇦
commented
Title: Too few arguments to function Drupal\Core\Form\ConfigFormBase::__construct(), 1 passed in /var/www/html/web/modules/contrib/psa_oecd_publishing/src/Form/OecdPublishingSettingsForm.php on line 60 and exactly 2 expected » Match changes to ConfigFormBase::__construct() in OecdPublishingSettingsForm

liam morland’s picture

liam morland
Primary language English
Location Ontario, CA 🇨🇦
commented
Status: Needs review » Fixed

Thanks!

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.