Overview

When selecting an SDC that has no editable props we should display a clear message to the user that there intentionally no fields to edit in the contextual right hand panel. Currently the panel is just empty which may lead someone to think it is broken.

Proposed resolution

Show a message like "This component has no user editable props" (TBC)

User interface changes

Current, poor, UI

CommentFileSizeAuthor
propless_sdc_panel.png76.12 KBjessebaker

Issue fork experience_builder-3473778

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

jessebaker created an issue. See original summary.

shyam_bhatt’s picture

shyam_bhatt
he/him
commented
Assigned: Unassigned » shyam_bhatt
jessebaker’s picture

jessebaker commented
Issue summary: View changes
wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Issue tags: +Novice
Parent issue: » #3450586: [META] Back-end Kanban issue tracker

This will need actual design later, but +1 for the current MVP proposal by @jessebaker!

This needs only a trivial addition to \Drupal\experience_builder\Form\ComponentPropsForm::buildForm().

Thanks for taking this on, @shyam_bhatt! 🥳

shyam_bhatt opened merge request !310

shyam_bhatt’s picture

shyam_bhatt
he/him
commented
Assigned: shyam_bhatt » Unassigned
Status: Active » Needs review
wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Status: Needs review » Reviewed & tested by the community

Just nits, but left suggestions. I think any /ui owner can make final tweaks and merge this :)

jessebaker’s picture

jessebaker commented
Status: Reviewed & tested by the community » Fixed

Merging, thanks for moving on this so quickly.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.