Problem/Motivation

At the moment the target size of the show/hide button is 24x16px. The minimum requirement for WCAG2.2 SC2.5.8 (https://www.w3.org/WAI/WCAG22/Understanding/target-size-minimum.html) would be 24x24px

Steps to reproduce

Inspect the icon on /user/login in devtools

Proposed resolution

Increase the target size to at least 24x24px by adding a padding or go for SC2.5.5 and increase the target size to 44x44px

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#7 after.png83.92 KBdhruv.mittal
#7 before.png77.55 KBdhruv.mittal

Issue fork view_password-3473319

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

rkoller created an issue. See original summary.

rkoller’s picture

rkoller
he/him
Primary language German
Location Nürnberg, Germany
commented
Issue summary: View changes
dhruv.mittal’s picture

dhruv.mittal commented
Assigned: Unassigned » dhruv.mittal

working on it

dhruv.mittal changed the visibility of the branch 3473319-increase-the-target to hidden.

dhruv.mittal changed the visibility of the branch 3473319-increase-the-target to active.

dhruv.mittal opened merge request !23

dhruv.mittal’s picture

dhruv.mittal commented
Assigned: dhruv.mittal » Unassigned
Status: Active » Needs review
StatusFileSize
new before.png77.55 KB
new after.png83.92 KB

Increased the target size to 24x24px kindly review

anacolautti made their first commit to this issue’s fork.

anacolautti’s picture

anacolautti commented
Status: Needs review » Fixed

Thanks everyone!

Since this was an arbitrary value to begin with, and this issue was opened almost two months ago and no other user complained about it, I think it should not bother anyone that we update it to match these requirements.

Merged and mark as fixed!

dhruv.mittal’s picture

dhruv.mittal commented

Thank you for merging the MR and changing the status to fix, But you forgot to give credit kindly check

anacolautti’s picture

anacolautti commented
anacolautti’s picture

anacolautti commented

Oh I'm sorry, I thought the commit was enough. I fixed that now. Thanks for letting me know, I need to check the other closed issues now...!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.