Hello @yogesh.k

I have noticed that the screenshot on the " admin > appearance" page is not visible .

Reason:

All the letters in the screenshot file name should be the small case but currently, currently is "Screenshot.png"

CommentFileSizeAuthor
#4 after_theme_screenshot.png259.17 KBesha_kundu
#4 before_theme_screenshot.png65.52 KBesha_kundu
Screenshot (1).png189.22 KBshubham_kumar

Issue fork rover-3473227

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

shubham_kumar created an issue. See original summary.

shubham_kumar opened merge request !15

shubham_kumar’s picture

shubham_kumar commented
Status: Active » Needs review
esha_kundu’s picture

esha_kundu commented
Assigned: shubham_kumar » Unassigned
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new before_theme_screenshot.png65.52 KB
new after_theme_screenshot.png259.17 KB

Hello,
I came across the same problem of missing screenshot in Appearance section. I've installed the theme version 1.0.7 in Drupal version 10.3.6.
When I visited /admin/appearance to install the theme, I saw the missing screenshot. I applied the MR!15, which resolved the issue. I've reviewed the MR and it seems to be a typo error in the naming of the image file, which was addressed.
IMO we should fix this.
Attached ss of before and after patch. Hence, moving to RTBC.
Thanks

Anonymous’s picture

Anonymous (not verified) commented

akulsaxena made their first commit to this issue’s fork.

Anonymous’s picture

Anonymous (not verified) commented

Rebased the branch.
The missing trailing comma's were causing PHPCS pipeline to fail so added trailing comma's in the twig file and fixed the PHPCS pipeline.

@yogesh.k MR seems to be working fine, Please review

Anonymous’s picture

Anonymous (not verified) commented
Status: Reviewed & tested by the community » Needs review

yogesh.k made their first commit to this issue’s fork.

yogesh.k’s picture

yogesh.k commented
yogesh.k’s picture

yogesh.k commented
Version: 1.0.7 » 2.0.0
Status: Needs review » Fixed
yogesh.k’s picture

yogesh.k commented
Status: Fixed » Closed (fixed)