Overview

Looks like a combination of a new test and a code change being merged in in quick succession has allowed a flakey test into 0.x. https://git.drupalcode.org/project/experience_builder/-/jobs/2671338

Proposed resolution

User interface changes

Issue fork experience_builder-3472579

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

jessebaker created an issue. See original summary.

jessebaker opened merge request !269

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Related issues: +#3472316: CI: remove `phpunit.image` override thanks to upstream fix

The warning started after #3472316: CI: remove `phpunit.image` override thanks to upstream fix was merged, very suspicious.

Ahhhh … it looks like https://git.drupalcode.org/project/experience_builder/-/pipelines/275317 failed, I merged that prematurely! Reverting…

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Title: Tests are sometimes failing » `components-slots.cy.js ` is sometimes failing
Issue tags: +e2e

Is this more accurate, @jessebaker?

jessebaker’s picture

jessebaker commented

@wim leers yes! The title was written too hastily (by me) in my attempt to get a fork up and running to attempt to fix it and then you jumped on it before I could rename it to be more specific, so thank you!

It looks like my attempted fix for the Cypress test has passed at least once. I'm going to run it a few more times to be a bit more reassured that it's truly solved.

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented

The distraction/off-topic "CI allowed to fail" one mentioned in #3 is now fixed: #3472316-11: CI: remove `phpunit.image` override thanks to upstream fix.

omkar-pd’s picture

omkar-pd commented

Sometimes tests fail with this error.
https://git.drupalcode.org/project/experience_builder/-/jobs/2675208

  1) General Experience Builder
       Can access XB UI and do basic interactions:
     TypeError: The following error originated from your application code, not from Cypress.
  > Cannot read properties of null (reading 'style')
When Cypress detects uncaught errors originating from your application it will automatically fail the current test.
This behavior is configurable, and you can choose to turn this off by listening to the `uncaught:exception` event.
https://on.cypress.io/uncaught-exception-from-application
      at <unknown> (http://localhost/web/modules/custom/experience_builder/ui/dist/assets/index.js?v=1:187:3580)
      at o (http://localhost/web/xb/node/1:3:448)
      at <unknown> (http://localhost/web/xb/node/1:3:821)

bnjmnm made their first commit to this issue’s fork.

bnjmnm opened merge request !297

bnjmnm’s picture

bnjmnm
he/him
Primary language English
Location Ann Arbor, MI
commented

I have a fix for this included in #3473155: Redux Sync all single-value types in the SDC test all props form, but also added a branch here with a partial version of the fix and it's still failing. Issue #3473155 is RTBC so we probably don't need to do much more here, but if there's a delay on that I can extract the full solution from that MR and provide it here.

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented

#3473155: Redux Sync all single-value types in the SDC test all props form landed and @jessebaker confirmed the fix over at #3473155-16: Redux Sync all single-value types in the SDC test all props form so … can we close this? 😄

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Assigned: jessebaker » Unassigned

Still happening, sadly: https://git.drupalcode.org/project/experience_builder/-/jobs/2727129

jessebaker’s picture

jessebaker commented

RE #12 it looks like the test is still flakey but it's flakey in a slightly different way now! I think that counts as progress.

I've just fixed conflicts so this branch now has the fixes that were added in #3473155: Redux Sync all single-value types in the SDC test all props form but I'm not able to look into this right now as other issues have priority.

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented

👍

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Assigned: Unassigned » jessebaker
Status: Active » Postponed (maintainer needs more info)

I don't think I've seen failures in the past 10 days!

jessebaker closed merge request !269

jessebaker’s picture

jessebaker commented
Version: » 0.x-dev
Assigned: jessebaker » Unassigned
Status: Postponed (maintainer needs more info) » Closed (outdated)

Closing as this was fixed elsewhere.

wim leers closed merge request !297