GitLab CI reports PHP_CodeSniffer errors/warnings which should be fixed.

Issue fork entity_list-3472333

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

sunil jolapara created an issue. See original summary.

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Title: Drupal Coding Standard is not matched » Fix the issues reported by PHP_CodeSniffer
Category: Bug report » Task
Status: Needs work » Active
Issue tags: -Drupal coding standard checks

avpaderno opened merge request !26

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Version: 3.0.8 » 3.0.x-dev
avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Issue summary: View changes
anwoon’s picture

anwoon commented
Assigned: Unassigned » anwoon
anwoon’s picture

anwoon commented
Status: Active » Needs work

  • anwoon committed 3afdce79 on 3.0.x authored by avpaderno 
    Issue #3472333: Fix the issues reported by PHP_CodeSniffer

  • anwoon committed b145cf12 on issue/entity_list-3472333 
    Issue #3472333 - Fix phpstan

  • anwoon committed a45e1a32 on issue/entity_list-3472333 
    Issue #3472333 - Continue to fix phpcs

  • anwoon committed e3c39547 on issue/entity_list-3472333 
    Issue #3472333 - Continue to fix phpcs

  • anwoon committed ff188404 on issue/entity_list-3472333 
    Issue #3472333 - Fix eslint and phpcs

  • anwoon committed ddeb4f1f on issue/entity_list-3472333 
    Issue #3472333 - Continue to fix code quality

  • anwoon committed d4d17ad7 on issue/entity_list-3472333 
    Issue #3472333 - Continue to fix code quality again

  • anwoon committed 9dff7973 on issue/entity_list-3472333 
    Issue #3472333 - Fix project words and eslint

  • anwoon committed a617c6ef on issue/entity_list-3472333 
    Issue #3472333 - Fix eslint

  • anwoon committed 4b74bbb2 on issue/entity_list-3472333 
    Issue #3472333 - Convert jquery to js vanilla and fix render entity list...

  • anwoon committed ec7cdcb3 on issue/entity_list-3472333 
    Issue #3472333 - Update missing documentation

  • anwoon committed 11ba720d on issue/entity_list-3472333 
    Issue #3472333 - Fix eslint

  • anwoon committed da649ce8 on issue/entity_list-3472333 
    Issue #3472333 - Fix eslint

  • anwoon committed 26b2bada on issue/entity_list-3472333 
    Issue #3472333 - Fix last eslint error

  • anwoon committed a915bd18 on issue/entity_list-3472333 
    Issue #3472333 - Fix concatenation
anwoon’s picture

anwoon commented
Assigned: anwoon » martygraphie
Status: Needs work » Needs review

  • anwoon committed f4b7e87e on issue/entity_list-3472333 
    Issue #3472333 - Fix documentation
martygraphie’s picture

martygraphie commented
Status: Needs review » Fixed

Merged thanks !

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.