Overview

We load the file preview.css into the preview iFrame but it has generic class names in it that could lead to our styles affecting the page being edited or the styles from the page somehow interfering with our styles.

Proposed resolution

Make the class names more unique.
Add warning to the top of the file.

User interface changes

Issue fork experience_builder-3472121

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

jessebaker created an issue. See original summary.

jessebaker opened merge request !254

jessebaker’s picture

jessebaker commented
Assigned: jessebaker » balintbrews
Status: Active » Needs review

  • jessebaker committed 5d885a2b on 0.x 
    Issue #3472121 by jessebaker: Mitigate class pollution from injected CSS
jessebaker’s picture

jessebaker commented
Assigned: balintbrews » Unassigned
Status: Needs review » Fixed

Merged!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.