Overview

Update the XB to use the latest Drupal 11 phpcs.xml.dist.

Proposed resolution

Match upstream changes:
Enforce strict types in tests

User interface changes

None

Issue fork experience_builder-3471448

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

omkar-pd created an issue. See original summary.

omkar-pd opened merge request !239

omkar-pd’s picture

omkar-pd commented
Status: Active » Needs review
danielveza’s picture

danielveza
he/him
Location Brisbane, AU
commented
Status: Needs review » Reviewed & tested by the community

Was going to open this issue myself but I see this one is already done. The pipeline is green, so that suggests the change is correct. But as a sanity check I cloned both phpcs files locally and diffed

local-machine:/tmp/test$ diff -s ex-phpcs core-phpcs 
Files ex-phpcs and core-phpcs are identical

Looks good to me! Lets get this in so our pipelines are green again

utkarsh_33’s picture

utkarsh_33 commented
Assigned: Unassigned » wim leers
Priority: Normal » Major

Assigning it to @wimleers for getting it in quickly and increasing the priority.

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Component: Page builder » Code
Assigned: wim leers » Unassigned
Related issues: +#3400434: Enforce strict types in tests

Again a trivial change. Nice to see #3400434: Enforce strict types in tests become a reality upstream :)

  • wim leers committed 773e0b1e on 0.x authored by omkar-pd 
    Issue #3471448 by omkar-pd, danielveza, utkarsh_33: Update XB to match...
wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.