Closed (fixed)
Project:
Experience Builder
Component:
Shape matching
Priority:
Critical
Category:
Feature request
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
30 Aug 2024 at 09:42 UTC
Updated:
25 Sep 2024 at 22:29 UTC
Jump to comment: Most recent, Most recent file

Comments
Comment #2
wim leersHow about
And we can make that simpler of course, for those who prefer that:
or perhaps even multiple aliases, for example:
Comment #3
lauriiiSomething like
$ref: json-schema-definitions://experience_builder.module/textareawould probably make sense 👍Comment #5
wim leersall-propstest SDC: https://git.drupalcode.org/project/experience_builder/-/merge_requests/2...\Drupal\experience_builder\SdcPropJsonSchemaType::computeStorablePropShape(): https://git.drupalcode.org/project/experience_builder/-/merge_requests/2...Less than 10 minutes 👍
Next step: updating
\Drupal\Tests\experience_builder\Kernel\SdcPropToFieldTypePropTestto expect more results.@lauriii, is that sample in
all-props.component.ymlto your liking? 😊Comment #6
wim leers… and now I've actually finished implementing this completely, because:
StringLongItemOverrideto specify an additional validation constraint that conveys newlines are actually allowed, allowing it to match againstjson-schema-definitions://experience_builder.module/textarea… is enough to make it all work 😊Ready for final review now 😄 @tedbow is the only other person who's been delving into this area, so assigning to him.
Comment #7
tedbowLooks good. 1 suggestion to make how this works clearer
Comment #8
tedbowAdd my small suggestion
Comment #10
tedbowComment #11
lauriiiReally nice to see we were able to land this issue this quickly! 🚀 Great team work @Wim Leers and @tedbow! 💯 👏
Comment #12
wim leersNote: the front-end does not yet allow typing in the
<textarea>. Root cause TBD.We have #3463842: [META] Redux sync on ALL prop types, not just ones with a single [value] property for that, unless @lauriii decides to increase the scope of #3462310: Component props form: map textarea, bool, and select elements to React components.
Comment #13
wim leersComment #14
kristen polShould there be a follow-up issue to add textarea schema refs to any of the existing XB components so there is an example?
Comment #15
wim leers