Problem/Motivation

Functions and methods lack clear parameter and return type declarations, causing potential type-related errors in the codebase.

Proposed resolution

Add explicit return type declarations to functions and methods to define expected return types clearly. This change improves code clarity, reduces ambiguity, and helps prevent type-related errors.

Issue fork role_expire-3471139

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

kuzyawkk created an issue. See original summary.

kuzyawkk opened merge request !16

kuzyawkk’s picture

kuzyawkk commented
Assigned: kuzyawkk » Unassigned
Status: Active » Needs review
anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented
Status: Needs review » Needs work

Thanks @kuzyawkk correct. We should use this chance to also fix the two related phpcs errors: https://git.drupalcode.org/issue/role_expire-3471139/-/pipelines/270211

rishabjasrotia made their first commit to this issue’s fork.

rishabjasrotia’s picture

rishabjasrotia commented
Assigned: Unassigned » rishabjasrotia
rishabjasrotia’s picture

rishabjasrotia commented

Hello @anybody, The phpcs issue is fixed.
https://git.drupalcode.org/issue/role_expire-3471139/-/pipelines/290956

rishabjasrotia’s picture

rishabjasrotia commented
Status: Needs work » Needs review
anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented
Assigned: rishabjasrotia » Unassigned

Thanks @rishabjasrotia! LGTM!! phpcs is also green now.

rcodina made their first commit to this issue’s fork.

rcodina’s picture

rcodina
Primary language Catalan
Location Barcelona
commented
Title: Return type declarations » Add parameter and return types declarations
Issue summary: View changes
rcodina’s picture

rcodina
Primary language Catalan
Location Barcelona
commented
Issue summary: View changes

Please, review.

anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented
Status: Needs review » Needs work

I again see phpcs issues now: https://git.drupalcode.org/project/role_expire/-/jobs/2857912

rcodina’s picture

rcodina
Primary language Catalan
Location Barcelona
commented
Status: Needs work » Needs review

Fixed.

rcodina’s picture

rcodina
Primary language Catalan
Location Barcelona
commented

@kuzyawkk @anybody @rishabjasrotia Please, review.

anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented
Status: Needs review » Reviewed & tested by the community

Thanks @rcodina LGTM! Please mind credits, when merging and setting the issues fixed :)

rcodina’s picture

rcodina
Primary language Catalan
Location Barcelona
commented

Setting issue credits.

  • rcodina committed f99380cb on 4.x authored by kuzyawkk 
    Issue #3471139 by kuzyawkk, rcodina, rishabjasrotia, anybody: Add...
rcodina’s picture

rcodina
Primary language Catalan
Location Barcelona
commented
Status: Reviewed & tested by the community » Fixed
rcodina’s picture

rcodina
Primary language Catalan
Location Barcelona
commented
Status: Fixed » Closed (fixed)

Included in new 4.1.0 release.