Overview

Add the boolean field to all props component so that it makes the scope of Component props form: make form elements match design clear.

Proposed resolution

User interface changes

Issue fork experience_builder-3470962

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

utkarsh_33 created an issue. See original summary.

utkarsh_33 opened merge request !221

utkarsh_33’s picture

utkarsh_33 commented
Assigned: Unassigned » wim leers
Status: Active » Needs review
wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Title: Add boolean field to all props components » Add boolean field to `all-props` component

It's a single component 😅

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Title: Add boolean field to `all-props` component » Add boolean prop to `all-props` component

… and it's not a field, but a prop.

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Assigned: wim leers » utkarsh_33
Status: Needs review » Needs work
Issue tags: +blocker
Related issues: +#3462310: Component props form: map textarea, bool, and select elements to React components

Linking the issue this blocks.

utkarsh_33’s picture

utkarsh_33 commented
Assigned: utkarsh_33 » wim leers
Status: Needs work » Needs review
wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Assigned: wim leers » Unassigned
Status: Needs review » Reviewed & tested by the community
wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Assigned: Unassigned » utkarsh_33
Status: Reviewed & tested by the community » Needs work

No longer passes because the test coverage #3455975: HTTP API: update /xb-component/{component_id} to list possible prop sources for current entity context added needs to be updated too 🙏

utkarsh_33’s picture

utkarsh_33 commented
Assigned: utkarsh_33 » wim leers
Status: Needs work » Needs review

Fixed the tests.Assigning it to @wimleers for reviews.

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Assigned: wim leers » Unassigned
Status: Needs review » Reviewed & tested by the community
wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Status: Reviewed & tested by the community » Fixed

  • Wim Leers committed e9f85273 on 0.x authored by utkarsh_33 
    Issue #3470962 by utkarsh_33, Wim Leers: Add boolean prop to `all-props...
wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Assigned: Unassigned » wim leers
Status: Fixed » Needs work

I see that the fixes I made and thought I pushed up had not been pushed up. Fixing that…

wim leers opened merge request !244

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Assigned: wim leers » Unassigned
Status: Needs work » Reviewed & tested by the community

  • wim leers committed 62551621 on 0.x 
    Issue #3470962 by wim leers: Add boolean prop to `all-props` component
wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.