Overview

Currently in order to close the insert panel, you need to click the + button again, which can be hard to find. A common pattern is to close a panel like this when clicking outside the panel.

Proposed resolution

Close the insert panel when clicking outside the panel.

User interface changes

CommentFileSizeAuthor
#4 Drupal Experience Builder.mp4165.96 KBomkar-pd

Issue fork experience_builder-3470933

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

lauriii created an issue. See original summary.

omkar-pd made their first commit to this issue’s fork.

omkar-pd opened merge request !222

omkar-pd’s picture

omkar-pd commented
Status: Active » Needs review
StatusFileSize
new Drupal Experience Builder.mp4165.96 KB
lauriii’s picture

lauriii
he/him
Primary language Finnish
Location Finland
commented
Issue tags: +Needs tests

Nice one @omkar-pd! Is this something you could write a Cypress test for? 😊

omkar-pd’s picture

omkar-pd commented

Thank you! 😊 I haven't written a Cypress test yet, but I'll try it. I'll dive in and see what I can do!

omkar-pd’s picture

omkar-pd commented

@lauriii, Added tests. Ready for review.

lauriii’s picture

lauriii
he/him
Primary language Finnish
Location Finland
commented
Status: Needs review » Needs work

Moving to needs work to get the MR feedback addressed

omkar-pd’s picture

omkar-pd commented
Status: Needs work » Needs review
omkar-pd’s picture

omkar-pd commented

@jessebaker,

I've addressed the feedback, please review it.

lauriii’s picture

lauriii
he/him
Primary language Finnish
Location Finland
commented
Assigned: Unassigned » jessebaker

jessebaker made their first commit to this issue’s fork.

jessebaker’s picture

jessebaker commented
Assigned: jessebaker » Unassigned
Status: Needs review » Needs work

@omkar-pd I attempted to get the tests passing but I have run out of time, unassigning and setting to Needs work for your (or someone else) to take another look.

omkar-pd’s picture

omkar-pd commented
Status: Needs work » Needs review

Tests are green now.

  • jessebaker committed d9c1bb3a on 0.x authored by omkar-pd 
    Issue #3470933 by omkar-pd, jessebaker: Close the insert panel when...
jessebaker’s picture

jessebaker commented
Status: Needs review » Fixed
Issue tags: -Needs tests

I just had to make one small change to the tests - each it() block should not depend on the previous test having run successfully to pass. They should be independent. I moved the 3 new tests into a single it block. See https://docs.cypress.io/guides/references/best-practices#Having-Tests-Re...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.