Postponed
Project:
Drupal core
Version:
main
Component:
image system
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
29 Aug 2024 at 07:35 UTC
Updated:
5 Sep 2024 at 16:26 UTC
Jump to comment: Most recent
Comments
Comment #2
mondrakeComment #4
mondrakeComment #5
andypostLooks good but probably needs 12.x issue to remove commented out type and
phpcs:disableComment #6
mondrakeComment #7
mondrakeAdded followup #3470951: Add return typehints for getWidth()/getHeigth in interfaces for D12 and @todo and @see in the MR to mimic what we'e doing in https://www.drupal.org/about/core/policies/core-change-policies/how-to-d...
Comment #8
andypostThanks, looks ready except
phpcs:disable Drupal.Commentingprobably as docs saidComment #9
mondrakeFixed, thank you
Comment #10
smustgrave commented* : ?int */;Not super familiar with examples like this but know I've seen it in parameters before.
Code wise believe this is good. But can a CR be added just in case there are some this may impact later.
Comment #11
mondrakeI think it's better wait on Symfony's [ErrorHandler] Add support for @return-type-will-change PR at this stage, that will provide a clear deprecation message for the need to introduce the typehint.
Comment #12
mondrakeAlso see #3333824: Enable existing interfaces to add return type hints with a deprecation message for implementors.