Problem/Motivation

Prevent future use of whitelist and blacklist in code.

Steps to reproduce

Proposed resolution

Add the following words as flag words for cspell.

  • blacklist
  • blacklisted
  • whitelist
  • whitelisted

Ignore 'whitelisted' in pipeline.yml. These must be ignored.
Ignore 'whitelist' in path_alias. Create followup to rename usages in path_alias, where it is in a service name and an interface.
Ignore 'blacklist' in autocomplete.js. They will be removed before Drupal 12.0.0.

Remaining tasks

Review
Create the followup

User interface changes

Introduced terminology

API changes

Data model changes

Release notes snippet

Issue fork drupal-3470895

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

quietone created an issue. See original summary.

quietone opened merge request !9372

quietone’s picture

quietone commented
Issue summary: View changes
Status: Active » Postponed
quietone’s picture

quietone commented
Issue summary: View changes
Status: Postponed » Needs review
smustgrave’s picture

smustgrave commented
Status: Needs review » Reviewed & tested by the community

Seems all instances have been captured and deprecations done for the path_alias stuff already.

longwave made their first commit to this issue’s fork.

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented

It looks like chromedriver have deprecated --whitelisted-ips and replaced it with --allowed-ips, let's see if this works.

quietone’s picture

quietone commented

Re-ran tests and all are passing.

catch closed merge request !9372

  • catch committed ff186c39 on 11.x 
    Issue #3470895 by quietone, longwave: Add blacklist and whitelist to the...
catch’s picture

catch
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Fixed

Every time we tried to replace blacklist/whitelist we ended up with a much clearer API afterwards, so makes sense to disallow them.

Committed/pushed to 11.x, thanks!

jonathan1055’s picture

jonathan1055 commented

The follow-up for Contrib #3524087: Add blacklist and whitelist to flagWords for all Contrib CI has just gone live.
Here's the change record
We also added suggested replacements, which are shown in the cspell log.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.