Closed (fixed)
Project:
Experience Builder
Component:
Meetings
Priority:
Normal
Category:
Plan
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
28 Aug 2024 at 12:54 UTC
Updated:
26 Sep 2024 at 11:49 UTC
Jump to comment: Most recent
| Kristen Pol (she/her) | Kristen :wave: California |
| kimb0 | Kim :wave::skin-tone-2: |
| guptahemant | Hemant, India |
| DanielVeza | Daniel :wave: |
| omkar-pd | Omkar, India :mario-wave: |
| lauriii | :wave: |
| Akhil Babu | Akhil from India |
| longwave | :wave: |
| Kristen Pol (she/her) | Wondering the ETA for when custom components will be viewable in XB so we can test components from #starshot-demo-design-system |
| Kristen Pol (she/her) | What is the plan for what XB will do and look like for Barcelona? |
| Kristen Pol (she/her) | What’s the ETA for when XB will be usable on Drupal CMS (it’s not currently compatible) |
| kimb0 | Checking if there are easy places to get involved. |
| Akhil Babu | Just found this code in experience_builder/src/PropShape.php// TRICKY: `attributes` is a special case — it is kind of a reserved // prop. // @see \Drupal\sdc\Twig\TwigExtension::mergeAdditionalRenderContext() // @see[#3352063]#comment-15277820 if ($prop_name === 'attributes') { assert($prop_schema['type'][0] === Attribute::class); continue; }The type of the 'attribute' prop should be always Drupal\Core\Template\Attribute . If type is changed to say 'string' , the component won't be available in XB. I would like to know why this is enforced. Is it a standard or is it done to support methods like attributes.addClass() in twig?cc: @wimleers (he/him) (edited) |
| guptahemant | Above query is in context of[#3469525] |
| smustgrave | Vision for theme builder:#3450621: [later phase] Theme Builder vision |
| Kristen Pol (she/her) | Finally got XB running locally after not looking at it for awhile :laughing: |
| smustgrave | On my todo list for next week so may be reaching out! |
| Kristen Pol (she/her) | I will have it documented by tomorrow so no problem |
| omkar-pd | Wrote my first test. :smile[#3467843] |
| longwave | unblocked[#3468106] so the preview is more like the real page |
| lauriii | We got first components from the demo design system working with @wimleers (he/him) which felt like a massive win: https://www.drupal.org/files/issues/2024-08-22/Screenshot%202024-08-22%2... |
| smustgrave | From @Kristen Pol (she/her) |
| lauriii | We tested this today and posted our findings in[#3454125]#comment-15739520. Conclusion is that there are steps to be taken on both sides still :smile: |
| Kristen Pol (she/her) | Uh… we weren’t ready for you :eyes: (edited) |
| Kristen Pol (she/her) | Let me read the comments though… I only yesterday switched the code to D11 and got rid of our module dependencies and we have some cleanup work that is happening this week |
| Kristen Pol (she/her) | For example, I didn’t know the “examples” needed to be in components because I don’t think that was in the SDC docs… I saw that yesterday in XB code and made a ticket and someone is working on it now (edited) |
| Kristen Pol (she/her) | I read it but am on my phone so I’ll reread when I’m on computer |
| smustgrave | From @Kristen Pol (she/her) |
| DanielVeza | I'm interested to hear about the plan post Barcelona too, if thats when we'll start to solidify things and have less hardcoded entity checks and stuff like that |
| longwave | as i understand it the plan for Barcelona is to have the frontend in some kind of demoable state (placing and editing components) but there will be no persistent storage yet |
| lauriii | As @longwave said, the plan for Barcelona is to have the FE in a demoable state for a content creator facing scenario. It doesn't have all the features or capabilities but it will give an idea of the user experience. |
| smustgrave | won't be there but super excited for the demo. Of all the new features experience builder is probably one of the few we could use for our government clients. |
| Kristen Pol (she/her) | I installed it yesterday… you can drag and drop and edit the props now… what might improve by then? Less buggy? Looks nicer? I’m trying to understand the delta so I have proper expectations |
| smustgrave | From @Kristen Pol (she/her) |
| lauriii | We can probably prioritize this in September. For now what we did was we tested the SDDS with Standard + XB. We discovered some blockers:#3454125: Implement temporary design system for the DrupalCon Barcelona demo#comment-15739520. These should be easy for us to fix in XB but there's also some steps to be take on the design system side. |
| Kristen Pol (she/her) | I already independently added issues for some yesterday and people are working on them… I’ll review the rest of the feedback and we’ll get it addressed asap |
Participants:
Kristen Pol, kim.pepper, Akhil Babu, guptahemant, smustgrave, omkar-pd, longwave, lauriii, DanielVeza
Comments
Comment #9
kristen polAdding credits
Comment #10
smustgrave commentedComment #11
wim leers