The 2026 Drupal Business Survey is open. Your response will help shape the future of the Drupal business ecosystem.Problem/Motivation
opentelemetry-php/sem-conv released 1.27.0 (https://github.com/opentelemetry-php/sem-conv/releases/tag/1.27.0).
In it there's a new deprecation (https://github.com/opentelemetry-php/sem-conv/commit/04685638c98df03419b...) that breaks our daily "updated deps" test pipeline on the PHPStan job with a cheery:
------ -----------------------------------------------------------------------
Line core/tests/Drupal/Tests/PerformanceTestTrait.php (in context of class
Drupal\FunctionalJavascriptTests\PerformanceTestBase)
------ -----------------------------------------------------------------------
474 Fetching deprecated class constant DEPLOYMENT_ENVIRONMENT of
interface OpenTelemetry\SemConv\ResourceAttributes:
Use `deployment.environment.name`
------ -----------------------------------------------------------------------
Steps to reproduce
See (for example) https://git.drupalcode.org/project/drupal/-/pipelines/264585
Proposed resolution
- Fix deprecation
- $ composer update open-telemetry/sem-conv since the fix (probably) won't pass on previous versions
If that fails to happen in a relatively short timespan: Suppress the deprecation, and create a new issue for it.
That way the daily "updated deps" test pipeline doesn't stop at the Lint-phase and keeps on catching other (for us) problematic updates in dependencies.
Remaining tasks
User interface changes
Introduced terminology
API changes
Data model changes
Release notes snippet
Issue fork drupal-3470235
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
compare
Comments
Comment #2
spokjeComment #4
spokjeTo me it looks like the current value of
ResourceAttributes::DEPLOYMENT_ENVIRONMENT, being'local', should now come from a GitLab variable?But what do I know about performance tests on core: Absolutely nothing!
Comment #5
spokjeComment #6
catchI think it can be s/DEPLOYMENT_ENVIRONMENT/DEPLOYMENT_ENVIRONMENT_NAME/g
Comment #7
spokjeThanks @catch.
That proved that:
a) I indeed have no knowledge about performance testing on core.
b) I completely misunderstood the needed changes in my comment #4.
Oh well, NR :)
Comment #8
catchThis looks great - we don't really use this as such because it's designed for sites using OpenTelemetry for production monitoring, whereas our (mis-) use of it for performance testing doesn't have any concept of stage/dev/prod. Looks like they just renamed the constant so straightforward change.
Comment #10
catchActual change is trivial so even though I RTBCed this I'm going to go ahead and commit it. Committed/pushed to 11.x, thanks!
I think we should do the same thing in 10.4.x, so moving there for backport.
Comment #13
spokjeComment #15
catchCommitted/pushed to 10.4.x, thanks!