Problem/Motivation

After a few other issues land, this is the only(?) remaining functional test that takes longer than 3 minutes to run on gitlab.

We can split the two additional methods added by the test out to their own class, to re-use all the methods from the main test, can skip any methods on the parent class in setUp().

Steps to reproduce

From my local:

Before:

After

Proposed resolution

Remaining tasks

User interface changes

Introduced terminology

API changes

Data model changes

Release notes snippet

Issue fork drupal-3469819

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

catch created an issue. See original summary.

catch’s picture

catch
he/him
Primary language English
commented
Issue summary: View changes
Status: Active » Needs review
Issue tags: +Test suite performance

catch opened merge request !9307

smustgrave’s picture

smustgrave commented
Status: Needs review » Reviewed & tested by the community

Breaking up didn't seem to lose coverage.

nod_ closed merge request !9307

  • nod_ committed d4555ed6 on 10.3.x 
    Issue #3469819 by catch: Split up jsonapi CommentTest

(cherry picked...
nod_’s picture

nod_
Primary language French
Location Lille
commented
Version: 11.x-dev » 10.3.x-dev
Status: Reviewed & tested by the community » Fixed

Committed and pushed 912146269c to 11.x and 8b52f2b0bd to 11.0.x and f0b14e9497 to 10.4.x and d4555ed6cd to 10.3.x. Thanks!

  • nod_ committed f0b14e94 on 10.4.x 
    Issue #3469819 by catch: Split up jsonapi CommentTest

(cherry picked...

  • nod_ committed 8b52f2b0 on 11.0.x 
    Issue #3469819 by catch: Split up jsonapi CommentTest

(cherry picked...

  • nod_ committed 91214626 on 11.x 
    Issue #3469819 by catch: Split up jsonapi CommentTest

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.