Overview

Update the XB to use the latest Drupal 11 phpcs.xml.dist.

Proposed resolution

Match upstream changes:
Fix DrupalPractice.Objects.GlobalFunction in ListBuilders

User interface changes

None

Issue fork experience_builder-3469782

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

omkar-pd created an issue. See original summary.

omkar-pd opened merge request !199

omkar-pd’s picture

omkar-pd commented
Related issues: +#3464595: Fix DrupalPractice.Objects.GlobalFunction in ListBuilders
omkar-pd’s picture

omkar-pd commented
Assigned: omkar-pd » Unassigned
Status: Active » Needs review

tedbow made their first commit to this issue’s fork.

  • tedbow committed 938ca03c on 0.x authored by omkar-pd 
    Issue #3469782: Update XB to match the latest Drupal 11 phpcs.xml.dist-...
tedbow’s picture

tedbow
he/him
Primary language English
Location Ithaca, NY, USA
commented
Status: Needs review » Fixed

Thanks @omkar-pd🎉

As for my review the `phpcs-rules-match-drupal-11` gitlabci job confirms the file is exactly the same as core as 11.x and our phpcs job still pass so I don't think there is any more review needed

tedbow’s picture

tedbow
he/him
Primary language English
Location Ithaca, NY, USA
commented

.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.