In #3454125-53: Implement temporary design system for the DrupalCon Barcelona demo, it became apparent that the ComponentPropsForm suddenly was being rendered in the new default theme!
This broke the live updating that #3462441: Contextual form values need to be integrated with Redux: start with single-property field types added.
stark (see #4) using a ThemeNegotiator for XB API routes.None.
Show commandsStart within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
changes
Comments
Comment #3
wim leersCan't get any core theme so far to break it. Perhaps there really was something exceptional about https://www.drupal.org/project/demo_design_system? 🤔
We'll have to figure out what.
Comment #4
lauriiiI don't think we should spend time figuring out what in that theme is breaking this. Regardless of the reason, we should ensure the forms are rendered with a theme that is known to work. I'm wondering if we should use Stark for this? Or maybe we could use a hidden theme specifically created for this so that it's not visible through the UI.
Comment #5
lauriiiWhy would we allow that? I don't see why would anyone do this.
Comment #6
wim leersYay for #4 and #5. Great.
Let's do this. And then let's get @bnjmnm to sign off on it.
Comment #7
wim leersThis is in the critical path for #3454094: Milestone 0.1.0: Experience Builder Demo — see #3454125-53: Implement temporary design system for the DrupalCon Barcelona demo.1.4.
Comment #9
utkarsh_33 commentedComment #10
wim leers@utkarsh_33: there's 2 nits to address, but they aren't commit-blocking.
I did find this doesn't actually quite work yet though, for subtle/tricky reasons, and I'm not quite sure how to proceed. I think @bnjmnm has ideas around this: https://git.drupalcode.org/project/experience_builder/-/merge_requests/1...
Comment #11
utkarsh_33 commentedAddressed feedbacks.
Comment #12
wim leers👍 Still needs final review from @bnjmnm.
Comment #13
wim leersStressing the importance
Comment #14
bnjmnmBrute force Stark as a dependency is fine.
Comment #15
wim leersGreat! I wasn't entirely confident that this made sense from a
semi_coupled.enginePOV — so great to have your +1 😊Comment #16
wim leersNeeds final sign-off from a BE reviewer. It's late in the European day, so asking @tedbow.
Comment #17
wim leersActually … I think @bnjmnm's sign-off alone is more than sufficient. No need to succumb to
CODEOWNERSas an iron first.This helps accelerate #3454125: Implement temporary design system for the DrupalCon Barcelona demo, so bypassing approval for this MR…
Comment #19
wim leers