Problem/Motivation

We can switch from a provider to a foreach in the trait, this reduces the time taken for two tests significantly.

Steps to reproduce

Before:
From my local install:

Time: 01:19.812, Memory: 4.00 MB

OK (24 tests, 379 assertions)

Daily test run:
https://git.drupalcode.org/project/drupal/-/jobs/2502554
Drupal\Tests\update\Functional\UpdateSemverCoreSecurityAvail 24 passes 83s
Drupal\Tests\update\Functional\UpdateSemverContribSecurityAv 25 passes 96s

After:

Time: 00:12.538, Memory: 6.00 MB

OK (1 test, 241 assertions)

Pipeline run:

Drupal\Tests\update\Functional\UpdateSemverCoreSecurityAvail   1 passes   21s                                      
Drupal\Tests\update\Functional\UpdateSemverContribSecurityAv   2 passes   39s  

Proposed resolution

Remaining tasks

User interface changes

Introduced terminology

API changes

Data model changes

Release notes snippet

Issue fork drupal-3469580

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

catch created an issue. See original summary.

catch’s picture

Issue summary: View changes
catch’s picture

Status: Active » Needs review

catch’s picture

Issue summary: View changes
smustgrave’s picture

Status: Needs review » Reviewed & tested by the community
Issue tags: +Needs Review Queue Initiative

Seems straight forward, no coverage lost that I can see.

  • nod_ committed bc16a13e on 10.3.x
    Issue #3469580 by catch, smustgrave: Speed up...

  • nod_ committed 57a060ea on 10.4.x
    Issue #3469580 by catch, smustgrave: Speed up...

  • nod_ committed 4630029b on 11.0.x
    Issue #3469580 by catch, smustgrave: Speed up...

  • nod_ committed 0066ab0f on 11.x
    Issue #3469580 by catch, smustgrave: Speed up...
nod_’s picture

Version: 11.x-dev » 10.3.x-dev
Status: Reviewed & tested by the community » Fixed

Committed and pushed 0066ab0fce to 11.x and 4630029ba4 to 11.0.x and 57a060ea43 to 10.4.x and bc16a13e3f to 10.3.x. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.