We have a baseline for all SDC YAML and README files that were generated from the script and manually fixed for linting issues.
We need to add required props, so someone to look at each component and make a judgement call to figure out which really should be required.
Go through all YAML files for base theme and subtheme and add required props as needed.
demo_design_system/components and demo_design_system/starshot_demo/components[name].component.yml filesWhen using XB, the required props will be required :)
Show commandsStart within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
changes, plain diff MR !34changes, plain diff MR !33
Comments
Comment #2
sea2709 commentedComment #3
kristen polThanks @sea2709!!!
Comment #4
kristen polNote that for now I have removed all "required" from all components so this is less of a priority right now. Still important to do at some point though :) [but removes the urgency]
Comment #5
kristen polSince we've removed required section for now, changing title and summary to reflect.
Comment #6
kristen pol@sea2709 I'm going to assign this to Joshua for now as I see you've been working on XB issues which are more important right now :)
Comment #7
kristen polWe can work on this but we may want to hold off on merging until this is fixed:
#3469855: Emptying a required value through the UI crashes the app (empty <input>, selecting "None" option in <select> …)
Comment #8
annmarysruthy commentedComment #9
kristen polThanks @annmarysruthy. I let @joshua1234511 know that someone was going to focus on this one.
Comment #15
annmarysruthy commentedRaised MR !34 for adding required props to component.yml files. Kindly review
Comment #16
kristen polAssigning to Jacob for review.
Comment #18
kristen polIt's looking pretty good but I noticed a few things. I didn't get that drush cr error btw.
Comment #19
kristen polAssigning for review.
Comment #20
kristen polLooks good for now. We can tweak as needed. I'll get this merged in. Thanks!
Comment #22
kristen polMerged!
Comment #24
kristen polNote that there may have been XB-related issues with using required, so I've commented them out for now. But, they are there if we want to uncomment and test as we are testing individual components.