Overview

When we add a new component/section either by dragging or with add section/component button the name property is lost both in the preview as well as the hierarchy view.

Attaching screenshots:-

contentmenu

Proposed resolution

User interface changes

CommentFileSizeAuthor
#3 Screenshot 2024-08-22 at 10.13.58 AM.png236.69 KButkarsh_33

Issue fork experience_builder-3469423

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

Utkarsh_33 created an issue. See original summary.

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Issue tags: +Needs screenshots
Parent issue: » #3450592: [META] Front-end Kanban issue tracker
utkarsh_33’s picture

utkarsh_33 commented
Issue summary: View changes
StatusFileSize
new Screenshot 2024-08-22 at 10.13.58 AM.png236.69 KB
utkarsh_33’s picture

utkarsh_33 commented
Issue tags: -Needs screenshots

Added screenshots!

Utkarsh_33 opened merge request !192

utkarsh_33’s picture

utkarsh_33 commented
Status: Active » Needs review
wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Assigned: Unassigned » utkarsh_33
Status: Needs review » Needs work
Issue tags: +Needs tests

Can we add test coverage for this in add-section.cy.js? 🙏

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Title: Name of a component/section is lost on adding a new component/section. » Name of a component/section is lost on adding a new component/section
Issue tags: -Needs tests
utkarsh_33’s picture

utkarsh_33 commented
Assigned: utkarsh_33 » jessebaker
Status: Needs work » Needs review

Replied to the question posted by Wim.Assigning it to @jessebaker for a review.

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Assigned: jessebaker » utkarsh_33
Status: Needs review » Needs work
utkarsh_33’s picture

utkarsh_33 commented
Assigned: utkarsh_33 » Unassigned
Status: Needs work » Needs review

I'm sorry if i misunderstood things and didn't gave proper answer @wimleers. I adjusted the tests accordingly.Marking it NR again.

jessebaker made their first commit to this issue’s fork.

jessebaker’s picture

jessebaker commented
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.