Problem/Motivation

To simplify #3433544: Automated Drupal 11 compatibility fixes for name, goal is to extract all things that are needed to get tests to pass on 10.2 and 10.3 so that they can be committed.

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Issue fork name-3469395

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

tyapchyc created an issue. See original summary.

tyapchyc opened merge request !20

tyapchyc’s picture

tyapchyc commented
Assigned: tyapchyc » Unassigned
Status: Active » Needs review
tyapchyc’s picture

tyapchyc commented

Hello @liam-morland, @alan-d, @heddn, @nkoporec, @rconstantine, @webflo

Could you please review this?

Thank you

liam morland’s picture

liam morland
Primary language English
Location Ontario, CA 🇨🇦
commented

It looks reasonable. There shouldn't be two spaces before coreVersion in its declaration. That method can probably be static.

liam morland’s picture

liam morland
Primary language English
Location Ontario, CA 🇨🇦
commented

Another approach would be to make a 2.0.x branch for Drupal 10.3 and later, including Drupal 11. Then there is no need for any version checks. Depending on the code, it can be difficult to make it compatible with versions earlier than 10.3 and with 11.

maxilein’s picture

maxilein commented

+1 for the 11 version.

tyapchyc’s picture

tyapchyc commented

Made coreVersion method static

heddn’s picture

heddn
Primary language English
Location Illinois
commented
Status: Needs review » Closed (outdated)

Drupal 10.2 won't be supported in parallel with Drupal 11 and this module. I don't think we need this BC layer any longer.

heddn closed merge request !20