issue

CommentFileSizeAuthor
#9 rover_breadcrumb_hover_effect.mov199.18 KBcleavinjosh
#8 breadcrumbHover.png7.98 KBkaaarrrtik
#6 rover_hover_effect_issue.mov282.77 KBcleavinjosh
#6 rover_breadcrumbs_after.png14.33 KBcleavinjosh
#6 rover_breadcrumbs_before.png13.13 KBcleavinjosh
#4 Screenshot 2024-08-29 at 4.35.54 PM.png22.64 KBhamid.ali
Screenshot 2024-08-21 at 9.25.18 AM.png10.41 KBalok_singh

Issue fork rover-3469337

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

alok_singh created an issue. See original summary.

hamid.ali’s picture

hamid.ali commented
Assigned: Unassigned » hamid.ali

Working on the fix

hamid.ali opened merge request !12

hamid.ali’s picture

hamid.ali commented
Assigned: hamid.ali » Unassigned
Status: Active » Needs review
StatusFileSize
new Screenshot 2024-08-29 at 4.35.54 PM.png22.64 KB

Fixed the breadcrumb spacing issue and created the MR for the same. I am attaching post-fix screenshot kindly review the same.

cleavinjosh’s picture

cleavinjosh commented
Assigned: Unassigned » cleavinjosh

I'll review this. Thank you

cleavinjosh’s picture

cleavinjosh commented
Assigned: cleavinjosh » Unassigned
Status: Needs review » Needs work
StatusFileSize
new rover_breadcrumbs_before.png13.13 KB
new rover_breadcrumbs_after.png14.33 KB
new rover_hover_effect_issue.mov282.77 KB

Hi @hamid.ali,

Thank you for providing an MR. I applied MR!12, it was applied smoothly and the changes were reflected.

➜  rover git:(1.0.6) curl https://git.drupalcode.org/project/rover/-/merge_requests/12.diff | patch -p1
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100   330    0   330    0     0    573      0 --:--:-- --:--:-- --:--:--   573
patching file css/style.css
➜  rover git:(1.0.6) ✗

Before:
Breadcrumbs Before

After:
Breadcrumbs After

Issue/Concern

  1. The breadcrumb links do not have a hover effect. It would be great to add another effect instead of just a mouse cursor change.
    Please see the video: Hover Issue

Please check and advise.
Thank you.

kaaarrrtik’s picture

kaaarrrtik commented
Assigned: Unassigned » kaaarrrtik
kaaarrrtik’s picture

kaaarrrtik commented
Assigned: kaaarrrtik » Unassigned
Status: Needs work » Needs review
StatusFileSize
new breadcrumbHover.png7.98 KB

Breadcrumb hover effect added.
breadcrumb hover

cleavinjosh’s picture

cleavinjosh commented
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new rover_breadcrumb_hover_effect.mov199.18 KB

Hi @kaaarrrtik,

Thank you for updating the MR. I applied MR!12, and it added a hover effect on the breadcrumbs.

Please refer to the video attached.

Thank you.

yogesh.k’s picture

yogesh.k commented
Version: 1.0.6 » 1.0.9
Status: Reviewed & tested by the community » Fixed
yogesh.k’s picture

yogesh.k commented
Status: Fixed » Closed (fixed)

yogesh.k closed merge request !12