issue

CommentFileSizeAuthor
#7 styledButton.png12.66 KBkaaarrrtik
#5 Screenshot from 2024-09-18 17-36-00.png52.38 KBriddhi.addweb
#5 Screenshot from 2024-09-18 17-35-49.png95.72 KBriddhi.addweb
#5 Screenshot from 2024-09-18 17-23-49.png114.87 KBriddhi.addweb
#4 Screenshot 2024-08-30 at 4.40.44 PM.png214.44 KBhamid.ali
Screenshot 2024-08-21 at 8.49.39 AM.png23.04 KBalok_singh

Issue fork rover-3469332

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

alok_singh created an issue. See original summary.

hamid.ali’s picture

hamid.ali commented
Assigned: Unassigned » hamid.ali

Working on the issue.

hamid.ali opened merge request !14

hamid.ali’s picture

hamid.ali commented
Assigned: hamid.ali » Unassigned
Status: Active » Needs review
StatusFileSize
new Screenshot 2024-08-30 at 4.40.44 PM.png214.44 KB

Created the MR for the same. I am attaching the post-fix screenshot below. Also, there are some Phpcs errors can someone look into the same since these are not from my code?

riddhi.addweb’s picture

riddhi.addweb commented
Status: Needs review » Needs work
StatusFileSize
new Screenshot from 2024-09-18 17-23-49.png114.87 KB
new Screenshot from 2024-09-18 17-35-49.png95.72 KB
new Screenshot from 2024-09-18 17-36-00.png52.38 KB

I tried to apply the patch and it applied cleanly, but no visual changes were displayed after applying the patch. Please look into it.

kaaarrrtik’s picture

kaaarrrtik commented
Assigned: Unassigned » kaaarrrtik
kaaarrrtik’s picture

kaaarrrtik commented
Assigned: kaaarrrtik » Unassigned
Status: Needs work » Reviewed & tested by the community
StatusFileSize
new styledButton.png12.66 KB

All changes are working as expected. RTBC++
buttonStyled

yogesh.k closed merge request !14

yogesh.k reopened merge request !14

yogesh.k made their first commit to this issue’s fork.

  • yogesh.k committed 60945982 on 1.0.x authored by hamid.ali 
    Issue #3469332: Read more and Add new comment needs to be styled
yogesh.k’s picture

yogesh.k commented
Version: 1.0.6 » 2.0.1
Status: Reviewed & tested by the community » Fixed
yogesh.k’s picture

yogesh.k commented
Status: Fixed » Closed (fixed)