Postponed
Project:
Starshot Demo Design System
Version:
1.0.x-dev
Component:
Documentation
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
21 Aug 2024 at 00:56 UTC
Updated:
18 Oct 2024 at 15:58 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
sea2709 commentedHi @Kristen,
I followed the documentation to set up my local. I was able to set up the site successfully, I just have a couple of comments
1. At the step "Provision content", it might be helpful to add a step to set the default theme appropriately (CivicTheme or Starshot Demo) before creating dummy content and structure.
2. I was not able to run storybook for Starshot Demo theme, not sure if this issue is reported or not, but there is a typo "wit" at line 18 in the file https://git.drupalcode.org/project/demo_design_system/-/blob/1.0.x/stars...
{% embed '@base/starshot-container/starshot-container.twig' wit {constrain: true} %}
it should be {% embed '@base/starshot-container/starshot-container.twig' with {constrain: true} %}
3. I was able to check experience builder by following the documentation steps. I think there have been some changes in XB recently that we need to do more steps. Based on the XB documentation https://git.drupalcode.org/project/experience_builder/-/blob/0.x/CONTRIB..., XB only works with article content type at this moment. And there was no article content type on my dev site, so I installed the standard profile "ddev drush si standard", and then enabled experience_builder. And the next step was to run "npm i" and "npm run build" in the folder web/modules/contrib/experience_builder/ui". I didn't need to run this step before, but on the latest XB version, I needed to add this step!
Comment #4
kristen polThanks @sea2709.
For #2, can you create an issue for that so we get it fixed propertly?
Comment #5
kristen polNote, Jacob was able to use the updated dev guide to install drupal_cms.
As for #1, makes sense. Let's leave that one here. Plus, we may get rid of that stuff for the demo theme testing anyway... it's TBD.
For #3, we are waiting on the XB team for feedback on how to properly install/use with drupal_cms.
Hopefully we can get that sorted tomorrow.
Comment #6
kristen polPostponing for now.
Comment #7
akhil babuI got these warnings during ddev start step
I ran ddev start again and all the errors were gone
Comment #8
sea2709 commented@akhil babu:
The first warning "No composer.lock file present. Updating dependencies to latest instead of installing from lock file", I think this one is normal, we don't have composer.lock in Drupal CMS repository, so developers can get the most up to date modules versions when they set up their local. When ddev start is run, composer install is kicked off, it's just a warning that composer will generate a lock file.
For the authentication error, I'm curious if you can see the recipes "notify_new_comments" in your project source code, it should be at "web/recipes/notify_new_comments". I think you can do a test to remove the folder "web/recipes/notify_new_comments" and then do "ddev composer install" again to see if this recipe is created back. If it shows up, then we're good :-)
Comment #9
akhil babuThanks @sea2709. The 'notify_new_comments' recipe was there in web/recipes. It's also getting recreated when I run composer install after deleting it.
Comment #10
sea2709 commented@akhil babu: I'm glad it works. I'm not sure about the authentication you ran into, but it looks like it just happened at the very first time.
@Kristen: For #2, I created a new issue and a MR to fix the issue as well. https://www.drupal.org/project/demo_design_system/issues/3469462#comment...
Comment #11
kristen polWelp. I heard from the XB lead last night that they recommend we use the standard install profile for testing for now because they haven't tested their stuff with starshot/drupal_cms... so... I'll need to update the core steps yet again to handle that.
Comment #12
kristen polI'm marking this one postponed and created this one:
#3469511: Update SDDS development guide to use standard Drupal 10 profile and XB
Comment #13
kristen polChange status.
Comment #14
kristen polDrupal CMS is still using 10.3.
Comment #15
kristen polSee #3481715: Target Drupal 11.1 for stable release without core patches applied