Closed (fixed)
Project:
Experience Builder
Component:
Page builder
Priority:
Major
Category:
Task
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
20 Aug 2024 at 17:04 UTC
Updated:
4 Sep 2024 at 08:19 UTC
Jump to comment: Most recent
I realized in #3468269: `ComponentTreeStructure` data type: simplify the stored structure that this issue might be hard to review because we have test code like this
'props invalid, using dynamic props' => [
[
'tree' => '{"' . ComponentTreeStructure::ROOT_UUID . '": [{"uuid":"dynamic-static-card2df","component":"xb_test_sdc:props-slots"}, {"uuid":"dynamic-static-card3","component":"xb_test_sdc:props-slots"},{"uuid":"dynamic-static-card4","component":"xb_test_sdc:props-slots"}]}',
'props' => '{"dynamic-static-card2df":{"heading-2":{"sourceType":"dynamic","expression":"ℹ︎␜entity:node:article␝title␞␟value"}},"dynamic-static-card3":{"heading-1":{"sourceType":"dynamic","expression":"ℹ︎␜entity:node:article␝title␞␟value"}},"dynamic-static-card4":{"heading":{"sourceType":"dynamic","expression":"ℹ︎␜entity:node:article␝title␞␟value"}}}',
],
],
(ComponentTreeTestTrait)
Because props and tree are json strings seeing the structure changes would be hard to grok
change these test cases to use php arrays, passed through json_encode() where possible
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
Comments
Comment #3
tedbowComment #4
wim leersComment #5
wim leers