issue

CommentFileSizeAuthor
#10 after_content_footer_space.png260.18 KBesha_kundu
#10 after_reset_pwd_footer_space.png117.38 KBesha_kundu
#10 after_register_footer_space.png199.74 KBesha_kundu
#10 after_login_footer_space.png51.25 KBesha_kundu
#10 before_content_footer_space.png172.91 KBesha_kundu
#10 before_extra_space_for_comment.png282.78 KBesha_kundu
#6 Reset-your-password.png67 KBdishakatariya
#6 Create-new-account.png600.87 KBdishakatariya
#6 Log-in.png63.03 KBdishakatariya
#5 Screenshot from 2024-08-23 12-52-59.png99.69 KBriddhi.addweb
#5 Screenshot from 2024-08-23 12-53-07.png264.35 KBriddhi.addweb
#5 Screenshot from 2024-08-23 12-53-20.png214.92 KBriddhi.addweb
#4 after-spacing-issue-resolve.png32.05 KBjaydeep_patel
1.jpg383.92 KBalok_singh

Issue fork pets_clinic-3469166

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

alok_singh created an issue. See original summary.

jaydeep_patel made their first commit to this issue’s fork.

jaydeep_patel opened merge request !12

jaydeep_patel’s picture

jaydeep_patel commented
Status: Active » Needs review
Issue tags: +CSS novice
StatusFileSize
new after-spacing-issue-resolve.png32.05 KB

Spacing issue has been resolved below the login, create new account and reset your password pages. Attached the screenshot for reference.

Thank you

riddhi.addweb’s picture

riddhi.addweb commented
StatusFileSize
new Screenshot from 2024-08-23 12-53-20.png214.92 KB
new Screenshot from 2024-08-23 12-53-07.png264.35 KB
new Screenshot from 2024-08-23 12-52-59.png99.69 KB

Without applying the patch the issue looks resolved. Also before and after applying the patch the issue looks the same. But If the patch is not applied then, the issue looks resolved. Attaching the SS for the same.

dishakatariya’s picture

dishakatariya commented
StatusFileSize
new Log-in.png63.03 KB
new Create-new-account.png600.87 KB
new Reset-your-password.png67 KB

Hi, I have also checked this issue, but it already looks good to me even without applying the patch.
Attaching the screenshots for reference.
Thanks!

ravi kant made their first commit to this issue’s fork.

ravi kant’s picture

ravi kant commented

The issue was due to gap was not added between main content and footer content. Also the comment section was adding space when comment section was not rendering.

esha_kundu’s picture

esha_kundu commented

I'll review this.

esha_kundu’s picture

esha_kundu commented
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new before_extra_space_for_comment.png282.78 KB
new before_content_footer_space.png172.91 KB
new after_login_footer_space.png51.25 KB
new after_register_footer_space.png199.74 KB
new after_reset_pwd_footer_space.png117.38 KB
new after_content_footer_space.png260.18 KB

Hello @ravi kant,
I encountered this issue when I cloned the repo and checked in the development version 1.0.x-dev however when the theme is installed using composer from the project page the spacing issue is not found. After installing the theme I visited the login, register, reset password, article content type pages. I faced the mentioned issue. For Article content type when the comment section is placed at the end of the page by configuring in Manage Display, an extra spacing is noticed if the comment section is not rendering. I applied the MR!12 which applied cleanly. I revisited the pages (login, register, reset password, article content type pages, page where comment section is not rendering) the spacing issue was resolved. I've also reviewed the MR and it looks good to me.
Attaching the ss for reference and moving to RTBC.
Thanks :)

ravi kant’s picture

ravi kant commented
Status: Reviewed & tested by the community » Fixed

Thank you everybody to work on this ticket.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.