Problem/Motivation

Twigs Field and Grid have warnings and we are unsure if we can just ignore them.

Steps to reproduce

grid.twig
WARNING Unused variable \"template_column_count\".

field.twig
WARNING Unused variable \"key\".

To get the errors:
twigcs ./components/02-molecules/field
twigcs ./components/00-base/grid

Proposed resolution

Someone who understands twigs better double checks this.

Remaining tasks

Check the twigs and make sure it's all okay. If it isn't then fix them if possible.

User interface changes

API changes

Data model changes

Comments

jacobadeutsch created an issue. See original summary.

kristen pol’s picture

kristen pol
she/her
Primary language English
Location Santa Cruz, CA, USA
commented
Assigned: kristen pol » alan.cole

Not sure we need to fix these but assigning to Alan for a quick look.

kristen pol credited alan.cole.

kristen pol’s picture

kristen pol
she/her
Primary language English
Location Santa Cruz, CA, USA
commented
Assigned: alan.cole » kristen pol
Status: Active » Reviewed & tested by the community

Fix is happening here:

https://git.drupalcode.org/project/demo_design_system/-/merge_requests/21

I have reviewed and we can test the update once it's been merged.

kristen pol’s picture

kristen pol
she/her
Primary language English
Location Santa Cruz, CA, USA
commented
Assigned: kristen pol » Unassigned
Status: Reviewed & tested by the community » Fixed

This has been merged.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.