Problem/Motivation

  • Add the artifacts (CFn) for the deployments for a Façade site

Issue fork facade-3468481

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

yas created an issue. See original summary.

yas opened merge request !50

yas opened merge request !51

yas closed merge request !50

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Needs work » Needs review

@baldwinlouie

Can you please review the patch? Thanks!

baldwinlouie’s picture

baldwinlouie commented
Status: Needs review » Needs work

@yas, thank you for the patch. I just have these minor comments. Aside from that, it looks good.

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Needs work » Needs review

@baldwinlouie

Thank you for your review. I found more typos and fixed them. Can you please review the patch again? Thanks!

baldwinlouie’s picture

baldwinlouie commented
Status: Needs review » Reviewed & tested by the community

@yas, thank you for the update on the patch! It looks good to me now.

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented

@baldwinlouie

Thank you for your review. I’ll merge the patch into 2.0.x; and close this issue as Fixed.

  • yas committed e70a0337 on 2.0.x 
    Issue #3468481 by yas, baldwinlouie: Add the artifacts (CFn) for the...
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.