When the SectorTocBlock block and TocChunkerFormatter field formatter are rendered on the same page they both make a call to TocManager to create a table of contents with the same field data.
TocManager statically caches the ToC - but we are not retrieving this at any point and end up initializing the same field value twice. This can be expensive when dealing with content that has a lot of elements.
Use the same id in the block and field formatted so an existing ToC can be reused if either has initialized it already.
The key should be unique to the node being rendered and the type of toc being generated (for reference - the module currently hard codes sector_toc in the toc block, but allows any toc to be configured in the field formatter. If these are different, then they should not share the same toc instance).
Show commandsStart within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
changes
Comments
Comment #3
ericgsmith commentedWill think about tests over the weekend
Comment #4
ericgsmith commentedWas hoping to make a simple unit test but mocking the field formatter was painful.
Test only changes pipeline shows:
> Failed asserting that actual size 2 matches expected size 1.
Think it is worth adding a proper functional js text to cover everything in this module - but this should be a OK start for this improvement.
Comment #5
ericgsmith commentedComment #6
ericgsmith commentedComment #9
rosk0Thanks Eric!