Create an image-style configuration Trait and bring it to play in FileCeFieldFormatter plugin.

Issue fork custom_elements-3468348

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

junkuncz created an issue. See original summary.

junkuncz opened merge request !79

junkuncz’s picture

junkuncz
Primary language Hungarian
Location Budapest
commented
Assigned: junkuncz » Unassigned
Status: Active » Needs review

Trait has been added and functions are called in FileCeFieldFormatter however there is no action yet (eg.: setting attribute in build()?) based on the configured image style. Honestly I'm not sure about it, the rest is ready for review.

roderik’s picture

roderik
Primary language Dutch
Location Amsterdam,NL / Budapest,HU
commented
Status: Needs review » Needs work
junkuncz’s picture

junkuncz
Primary language Hungarian
Location Budapest
commented
Status: Needs work » Needs review
roderik’s picture

roderik
Primary language Dutch
Location Amsterdam,NL / Budapest,HU
commented
Status: Needs review » Needs work
junkuncz’s picture

junkuncz
Primary language Hungarian
Location Budapest
commented
Status: Needs work » Needs review

  • roderik committed 92aa9899 on 3.x authored by junkuncz 
    Issue #3468348 by junkuncz, roderik: Create a image-style dropdown to...
roderik’s picture

roderik
Primary language Dutch
Location Amsterdam,NL / Budapest,HU
commented
Status: Needs review » Fixed

Thanks. While I was testing, I encountered some PHP warnings which I fixed - along with tinkering with some strings.

Merged! (I don't know what that "18 commits" message is about, I only added a single commit and did not force-push. The only thing that happened is the "merge" button did not work the first time, because I had not approved the MR yet.)

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.