Note custom_elements_ui module is only available in v3 of custom_elements.

Check on install, and enable if present.

On update:
Since we do not have power over which version is installed, and there is no requirement to upgrade yet (so e.g. a lupus_decoupled upgrade to v1.0 may leave custom_elements at v2...) I imagine we might do several repeated checks in update hooks in several version updates?

As discussed with @fago, let's do the update hook in custom_elements 2 -> v3 update. Then we don't need to guess / do repeated checks. And it's fair to expect all people who upgrade from v2, to want to have the UI enabled.

Issue fork lupus_decoupled-3468313

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

roderik created an issue. See original summary.

roderik’s picture

roderik
Primary language Dutch
Location Amsterdam,NL / Budapest,HU
commented
Issue summary: View changes
fago’s picture

fago
Primary language German
Location Vienna
commented
Assigned: Unassigned » useernamee
roderik’s picture

roderik
Primary language Dutch
Location Amsterdam,NL / Budapest,HU
commented
Issue summary: View changes
useernamee’s picture

useernamee commented

Addressed in: #3469959: Auto-enable Custom Elements UI during upgrade

useernamee’s picture

useernamee commented
Status: Active » Needs review
roderik’s picture

roderik
Primary language Dutch
Location Amsterdam,NL / Budapest,HU
commented
Status: Needs review » Needs work

Install hook goes here, per the description. (Check if the module is actually present, because it can still be v2.)

useernamee opened merge request !88

useernamee’s picture

useernamee commented
Assigned: useernamee » roderik
Status: Needs work » Needs review
fago’s picture

fago
Primary language German
Location Vienna
commented
Title: Auto-enable Custom Elements UI when available » Auto-enable Custom Elements UI during upgrade

ok, let's clarify this in the title then.

  • fago committed 3d3f4a1e on 1.x authored by useernamee 
    Issue #3468313 by useernamee, roderik: Auto-enable Custom Elements UI...
fago’s picture

fago
Primary language German
Location Vienna
commented
Status: Needs review » Fixed
fago’s picture

fago
Primary language German
Location Vienna
commented
Title: Auto-enable Custom Elements UI during upgrade » Auto-enable Custom Elements UI during installation

ops, wrong issue. Now I accidentially merged this with a wrong description, this is for install - not upgrade.

  • fago committed 3d3f4a1e on 3336148-forms-simplified authored by useernamee 
    Issue #3468313 by useernamee, roderik: Auto-enable Custom Elements UI...

roderik opened merge request !95

roderik’s picture

roderik
Primary language Dutch
Location Amsterdam,NL / Budapest,HU
commented
Status: Fixed » Needs review

custom_elements_ui isn't actually enabled. See https://git.drupalcode.org/project/lupus_decoupled/-/merge_requests/95/d... for fix.

(I didn't want to open a new issue, that would IMHO get more confusing.)

roderik’s picture

roderik
Primary language Dutch
Location Amsterdam,NL / Budapest,HU
commented
Assigned: roderik » Unassigned

  • fago committed 6f94a472 on 1.x authored by roderik 
    Issue #3468313 by roderik, useernamee, fago: Auto-enable Custom Elements...
fago’s picture

fago
Primary language German
Location Vienna
commented
Status: Needs review » Fixed

thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.