Problem/Motivation

It would be great to have a "brevo_commerce" submodule to integrate Brevo's E-commerce capabilities within Drupal Commerce.

Issue fork brevo-3467875

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

Anybody created an issue. See original summary.

renrhaf’s picture

renrhaf
Primary language French
Location 📍 Strasbourg 🐦🦜
commented
Version: » 1.0.x-dev

Future releases of the module might implement some new features like newsletter subscription.
Can you describe more in details, or with some capture, what is the expected behavior and where the checkbox should be located exactly ?
Thanks !

anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented
Related issues: +#3470738: Brevo newsletter (un)subscribe (via SDK)

Very cool @renrhaf nice to see progress here!
I created #3470738: Brevo newsletter (un)subscribe (via SDK) as a first step to postpone the UI / form features on it.

Perhaps the functionality should be split into submodules?

Perhaps one general core module just providing the SDK / API integration and then submodules for

  • Mail sending API
  • Newsletter subscriptions API
  • Newsletter subscription UI (registration / user profile / block)
  • ...
  • up to contrib extending modules like commerce checkout integration?

I'm sure you have a plenty of ideas! :)

anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented
Issue summary: View changes
Status: Active » Postponed
renrhaf’s picture

renrhaf
Primary language French
Location 📍 Strasbourg 🐦🦜
commented
Status: Postponed » Needs work

This will be integrated in the module, but I don't have any time target to give yet.

renrhaf’s picture

renrhaf
Primary language French
Location 📍 Strasbourg 🐦🦜
commented
Title: Drupal Commerce checkout integration? » Drupal Commerce integration
Issue summary: View changes
anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented
Issue summary: View changes

@renrhaf we'd like to add this as submodule - especially for a newsletter subscription checkbox in checkout as first step. Are you fine with adding a submodule brevo_commerce?

We'd then prepare a MR here.

@grevil: API calls can be found here: #3470738: Brevo newsletter (un)subscribe (via SDK)

grevil’s picture

grevil commented
Assigned: Unassigned » grevil
Status: Needs work » Active
renrhaf’s picture

renrhaf
Primary language French
Location 📍 Strasbourg 🐦🦜
commented

Hi @anybody, @grevil, yes sure you can go ahead ! Thank you for your contribution !

grevil’s picture

grevil commented

Great stuff, thank you, @renrhaf! 🎉

grevil’s picture

grevil commented
Status: Active » Postponed

Seems like all changes from https://git.drupalcode.org/project/brevo/-/commit/9d6fa6b549ca3814f247a3... got reverted in current 1.0.x again?

grevil’s picture

grevil commented

Yep, they all where reverted through https://git.drupalcode.org/project/brevo/-/commit/43b79f08f9c20fc22ba19a... again.

grevil opened merge request !5

grevil’s picture

grevil commented

POSTPONED on #3536068: Regression: Revert accidental removal of BrevoFactory sdk client creation.

grevil’s picture

grevil commented
Status: Postponed » Needs work

This should do the trick, I will test it now.

grevil’s picture

grevil commented

Alright, this is almost finished, need to move parts of the code to the decorator and wait for #3536068: Regression: Revert accidental removal of BrevoFactory sdk client creation to resolve. But I am away for a 1 1/2 weeks now, but I will finish it then!

grevil’s picture

grevil commented
Assigned: grevil » Unassigned
Status: Needs work » Needs review

Ready for review!

grevil’s picture

grevil commented
Assigned: Unassigned » anybody

Now its ready for review!

grevil’s picture

grevil commented

Now for real!

mazze’s picture

mazze commented

Great to see the Commerce Checkout option to be integrated. Do you have an idea when it will be merged? I installed the DEV version and did not find any options to activate it.

anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented

@mazze thank you! It still needs to be reviewed and tested, please see the MR attached. It's not yet in dev.

  • renrhaf committed 2495ea7b on 1.0.x 
    Issue #3467875 by Grevil: Add Drupal Commerce integration.

Adds...

  • renrhaf committed eaa46ba5 on 1.0.x 
    Issue #3467875: Fix PHP 8.4+ compatibility and config storage in...

  • renrhaf committed 77a88c8d on 1.0.x 
    Issue #3467875: Fix remaining issues from code review.

- Add NULL check...

renrhaf closed merge request !5

renrhaf’s picture

renrhaf
Primary language French
Location 📍 Strasbourg 🐦🦜
commented
Status: Needs review » Fixed

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented
Assigned: anybody » Unassigned

Thank you very very much @renrhaf sorry we had busy weeks, so we didn't yet make it to the final changes.

Greaet work!!

grevil’s picture

grevil commented

Yea, thanks @renrhaf!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

mikewiener’s picture

mikewiener commented

Does this integration allow for sending data to the Brevo ecommerce dashboard?

https://help.brevo.com/hc/en-us/articles/6009780106002-Discover-our-eCom...

https://developers.brevo.com/docs/add-the-ecommerce-app
https://developers.brevo.com/docs/ecommerce-and-tracker-events