Overview

Update the XB to use the latest Drupal 11 phpcs.xml.dist.

Proposed resolution

Match upstream changes:
Ignore phpstan-tmp in phpcs.xml.dist
Enable Drupal.Commenting.VariableComment.IncorrectVarType

User interface changes

None

Issue fork experience_builder-3467818

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

omkar-pd created an issue. See original summary.

omkar-pd opened merge request !165

omkar-pd’s picture

omkar-pd commented
Status: Active » Needs review

bnjmnm made their first commit to this issue’s fork.

Utkarsh_33 made their first commit to this issue’s fork.

utkarsh_33’s picture

utkarsh_33 commented
Assigned: Unassigned » wim leers
Priority: Normal » Critical

As this is a critical issue as it affects every MR's CI, so marking it critical and assigning it to Wim so that it can get in ASAP.

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Assigned: wim leers » Unassigned
Status: Needs review » Needs work
Issue tags: +Needs issue summary update

See MR review 😅

Also: can you please link the relevant upstream issues? 🙏 (Tagged Needs issue summary update for that.)

utkarsh_33’s picture

utkarsh_33 commented

This is failing as there is an upstream change in https://www.drupal.org/project/drupal/issues/3467397. I have opened a follow-up issue for that
Update XB to match the latest Drupal 11 phpcs.xml.dist- 2024-08-14.

utkarsh_33’s picture

utkarsh_33 commented

Ohh I didn't see that you updated the changes in the same MR.You can mark the issue as duplicated.

omkar-pd’s picture

omkar-pd commented
Issue summary: View changes
Status: Needs work » Needs review

Updates IS with relevant upstream issues.

omkar-pd’s picture

omkar-pd commented

Okay @Utkarsh

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Status: Needs review » Reviewed & tested by the community
Issue tags: -Needs issue summary update
Related issues: +#3466689: Ignore phpstan-tmp in phpcs.xml.dist, +#3467397: Enable Drupal.Commenting.VariableComment.IncorrectVarType

Thanks for finding those upstream issues! Can you next time add them to the related issues?

Green → 🚢

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Status: Reviewed & tested by the community » Fixed

  • Wim Leers committed 755f757f on 0.x authored by omkar-pd 
    Issue #3467818 by omkar-pd, Utkarsh_33, bnjmnm: Update XB to match the...
omkar-pd’s picture

omkar-pd commented

Yes, I will update them in related issues next time.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.