Core change record: Plugin types should use PHP attributes instead of annotations

Issue fork votingapi_widgets-3467759

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

TR created an issue. See original summary.

sourav_paul’s picture

sourav_paul
Location Kolkata
commented
Assigned: Unassigned » sourav_paul

Sourav_Paul opened merge request !11

sourav_paul’s picture

sourav_paul
Location Kolkata
commented
Assigned: sourav_paul » Unassigned
Status: Active » Needs review

Converted the VotingApiWidget annotation to an attribute, Can't find the discovery plugin...

tr’s picture

tr commented

Added attributes to the plugins. The discovery class is the plugin manager. Added properties to the attribute class, added comments. Corrected PHPCS errors.

  • TR committed 667576dc on 2.0.x authored by Sourav_Paul 
    Issue #3467759 by TR, Sourav_Paul: [10.3] Convert VotingApiWidget...
tr’s picture

tr commented
Status: Needs review » Fixed
reece.oliver’s picture

reece.oliver commented

@TR I think its might be causing this but just trying to get a Drupal 11 env up to do some development for migration. I need the votingapi_widgets module installed and im doing some things focused around that meaning im installing the 2.0.x branch as it has 11 support for now and hitting this error

14:25:39 WATCHDOG: [ERROR] [node] Drupal\Component\Plugin\Exception\PluginNotFoundException: The "fivestar" plugin does not exist. Valid plugin IDs for Drupal\votingapi_widgets\Plugin\VotingApiWidgetManager are:

Its seems like its not able to discover any of the plugins

tr’s picture

tr commented

Yes you are correct, I forgot to move the plugins into the new directory (src/Plugin/VotingApiWidget instead of src/Plugin/votingapi_widgets) and change the corresponding namespace in the plugins.

I will post the changes later today - don't have time now.

This is one example of why this module desperately needs test cases - this would have been caught by even the simplest automated test.

tr’s picture

tr commented
Status: Fixed » Active

TR opened merge request !18

tr’s picture

tr commented
Status: Active » Needs review

I think MR !18 should fix it for you. If you can download the patch https://git.drupalcode.org/project/votingapi_widgets/-/merge_requests/18... and try it out I would appreciate it.

reece.oliver’s picture

reece.oliver commented

Thanks, that seems to have done the job I not longer receive the error but the fivestars are no longer appearing might be something I need to change on my end so will look into it.

reece.oliver’s picture

reece.oliver commented

Just a quick update - Yeah it was something I was doing wrong all is working with the changes thanks for the quick turnaround @TR

  • TR committed 53cfd303 on 2.0.x 
    Issue #3467759 by TR, reece.oliver: [10.3] Convert VotingApiWidget...
tr’s picture

tr commented
Status: Needs review » Fixed

Thanks. Committed.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.