Discovered in #3463999: Auto-create/update Component config entities for all discovered SDCs that meet XB's minimum criteria, we need to add fieldInstanceSettings as config schema is split between field.storage_settings.* and field.field_settings.*
Add fieldInstanceSettings sibling to fieldStorageSettings in StorablePropShape, CandidateStorablePropShape and update schema + Unit Tests accordingly.
Show commandsStart within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
changes
Comments
Comment #2
wim leersThanks for creating this, @f.mazeikis!
This is an oversight/oversimplification I introduced in #3461499: Support complex SDC prop shapes: introduce (Storable)PropShape to compute field type storage settings: I assumed we'd only need field storage settings, but as of #3462709: Introduce `hook_storable_prop_shape_alter()`, use it to prefer the Media Library widget for "image" PropShape if Media Library is installed, we actually also need field instance settings.
Comment #4
wim leersThanks, @f.mazeikis — you were 99% there!
I only had to fix 1 bug and 1 oversight to get this to green:
- https://git.drupalcode.org/project/experience_builder/-/merge_requests/1...
- https://git.drupalcode.org/project/experience_builder/-/merge_requests/1...
You'll be unblocked on #3463999: Auto-create/update Component config entities for all discovered SDCs that meet XB's minimum criteria in a few minutes 😊
Comment #6
wim leersComment #7
wim leersOops: #3469729: Follow-up for #3467712: field instance settings lost in ComponentPropsForm.
Comment #8
wim leers