Problem/Motivation

Several attributes are not supported and are stripped from an iframe element if they already existed on it before the editor was loaded:

  • allowfullscreen
  • allow
  • id
  • sandbox

Steps to reproduce

Proposed resolution

I think we should add a UI toggle for the "allowfullscreen" attribute. For the "allow", "id", and "sandbox" attributes, just allow them to be added to the iframe, but don't provide a UI to manipulate them (for now, anyway).

Remaining tasks

User interface changes

API changes

Data model changes

Issue fork ckeditor_iframe-3467454

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

bkosborne created an issue. See original summary.

bkosborne opened merge request !12

bkosborne’s picture

bkosborne
Primary language English
Location New Jersey, USA
commented
Status: Active » Needs review
bkosborne’s picture

bkosborne
Primary language English
Location New Jersey, USA
commented
Title: Support for "allowfullscreen" » Allow "allowfullscreen", "id", and "allow" attributes
Issue summary: View changes
bkosborne’s picture

bkosborne
Primary language English
Location New Jersey, USA
commented
Title: Allow "allowfullscreen", "id", and "allow" attributes » Allow "allowfullscreen", "id", "allow", and "sandbox" attributes
Issue summary: View changes
bkosborne’s picture

bkosborne
Primary language English
Location New Jersey, USA
commented
Status: Needs review » Fixed

Been using this in production for a few months

bkosborne’s picture

bkosborne
Primary language English
Location New Jersey, USA
commented

  • bkosborne committed 476e4ab3 on 3.0.x 
    Issue #3467454 by bkosborne: Allow "allowfullscreen", "id", "allow", and...
bkosborne’s picture

bkosborne
Primary language English
Location New Jersey, USA
commented
Issue summary: View changes
bkosborne’s picture

bkosborne
Primary language English
Location New Jersey, USA
commented

Included in 3.0.0-beta2

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.