Problem/Motivation

This issue is for Madhukar to test the SDC conversion script and the guide using:

  • starshot_demo/components/01-atoms/starshot-heading

Steps to reproduce

Proposed resolution

Go through the conversion guide and try to convert the component using the script and report any feedback.

Remaining tasks

  • Review guide
  • Follow guide to use the script
  • Convert starshot_demo/components/01-atoms/starshot-heading
  • Report feedback here

User interface changes

API changes

Data model changes

Issue fork demo_design_system-3467288

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

Kristen Pol created an issue. See original summary.

madhukar k’s picture

madhukar k commented
madhukar k’s picture

madhukar k commented
Assigned: Unassigned » madhukar k

Madhukar K opened merge request !10

madhukar k’s picture

madhukar k commented
Assigned: madhukar k » Unassigned
Status: Active » Needs review

Tested SDC conversion script and guide with starshot_demo/components/01-atoms/starshot-heading. 2 new files are generated Readme.md file and starshot_demo/components/01-atoms/starshot-heading/starshot-heading.component.yml .

Merge request is ready for review.

kristen pol’s picture

kristen pol
she/her
Primary language English
Location Santa Cruz, CA, USA
commented
Status: Needs review » Needs work

Thanks! Note that baseline YAMLs and MDs were added for all components so please take a look at those and see if you find anything that needs adjusting.

kristen pol’s picture

kristen pol
she/her
Primary language English
Location Santa Cruz, CA, USA
commented
Status: Needs work » Fixed

I've compared against the baseline and it looks good (note that we've removed required props for now).

kristen pol closed merge request !10

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.