Problem/Motivation
When using the Gin admin theme (which is used for Starshot) and going to the CivicTheme basic page, the styling for the dropdown for adding components is broken so you can't see what to add.
Gin theme

Claro theme

Steps to reproduce
Proposed resolution
This is probably a Gin+paragraphs issue so check the Gin issue queue to see if there is a patch. If not, create one and we can use it here.
Remaining tasks
Find or create patch for Gin.
User interface changes
User will be able to see dropdown items.
API changes
Data model changes
| Comment | File | Size | Author |
|---|
Comments
Comment #2
kristen polAdd screenshots.
Comment #3
kristen polUpdate screenshot sizes.
Comment #4
boulaffasae commentedComment #5
kristen polThanks 🙏 I’ll try the patch
Comment #6
kristen polAssigning to Joshua to test out.
Comment #7
kristen polBumping priority.
Comment #8
joshua1234511Tested the patch from issue https://www.drupal.org/project/gin/issues/3242554
Patch tested from Merge Request https://git.drupalcode.org/project/gin/-/merge_requests/459
Case tested for mention issues

Case 1: when the dropdown is at the top
Case 2: when the dropdown is somewhere in the bottom


@kristen-pol
Not sure of the status that needs to be set to this issue, As patch needs to be applied to the https://github.com/phenaproxima/starshot-prototype.git
Comment #9
joshua1234511Comment #10
boulaffasae commentedI think we should integrate the patch for now, and follow the updates in the Gin issue.
I updated the docs: https://www.drupal.org/community-initiatives/starshot-demo-design-system...
Comment #11
kristen polYeah… was just wanting to make sure it worked and add it to dev guide 👍
Comment #12
kristen polJoshua, if you could review the docs change, that would be great
Comment #13
joshua1234511I reviewed the document changes, updated the wording, and added a reference to the ongoing issue with the Gin theme.
Reference: https://www.drupal.org/community-initiatives/starshot-demo-design-system...
Comment #14
kristen polThanks 🙏 I’ll see if someone will review the doc steps work.
Comment #15
kristen polUnassigning from me for now.
Comment #16
annmarysruthy commentedUnable to review: Tried reviewing the changes in documentation https://www.drupal.org/community-initiatives/starshot-demo-design-system/sdds-development-guide. Currently unable to setup the local due to InvalidComponentException.
Error :
Drupal\Core\Render\Component\Exception\InvalidComponentException: [props.properties.link.properties] Array value found, but an object is required/n[props.properties.image.properties] Array value found, but an object is required in Drupal\Core\Theme\Component\ComponentValidator->validateDefinition() (line 121 of core/lib/Drupal/Core/Theme/Component/ComponentValidator.php).
Comment #17
kristen polCreated new issue:
#3469319: InvalidComponentException: [props.properties.link.properties] Array value found
Comment #18
kristen polI have confirmed that using the patch steps that were added to the dev guide fixes the issue.
We should get the Gin patch added to:
https://www.drupal.org/project/drupal_cms
Leaving this RTBC until we have an issue for that.
Comment #19
kristen polSince this is only needed for Paragraphs and Drupal CMS won't be using Paragraphs, let's not add this as an issue there.