Problem/Motivation

When using the Gin admin theme (which is used for Starshot) and going to the CivicTheme basic page, the styling for the dropdown for adding components is broken so you can't see what to add.

Gin theme

Claro theme

Steps to reproduce

Proposed resolution

This is probably a Gin+paragraphs issue so check the Gin issue queue to see if there is a patch. If not, create one and we can use it here.

Remaining tasks

Find or create patch for Gin.

User interface changes

User will be able to see dropdown items.

API changes

Data model changes

CommentFileSizeAuthor
#8 Screenshot 2024-08-12 at 3.01.59 PM.png62.53 KBjoshua1234511
#8 Screenshot 2024-08-12 at 2.58.09 PM.png72.44 KBjoshua1234511
#8 Screenshot 2024-08-12 at 2.58.02 PM.png56.69 KBjoshua1234511
#2 Screenshot 2024-07-30 at 3.41.19 PM.png85.63 KBkristen pol
#2 Screenshot 2024-08-09 at 12.28.28 PM.png72.71 KBkristen pol

Comments

Kristen Pol created an issue. See original summary.

kristen pol’s picture

kristen pol
she/her
Primary language English
Location Santa Cruz, CA, USA
commented
Issue summary: View changes
StatusFileSize
new Screenshot 2024-08-09 at 12.28.28 PM.png72.71 KB
new Screenshot 2024-07-30 at 3.41.19 PM.png85.63 KB

Add screenshots.

kristen pol’s picture

kristen pol
she/her
Primary language English
Location Santa Cruz, CA, USA
commented
Issue summary: View changes

Update screenshot sizes.

boulaffasae’s picture

boulaffasae commented
Related issues: +#3242554: contents of dropdown button go to the left and can be off the visible page
kristen pol’s picture

kristen pol
she/her
Primary language English
Location Santa Cruz, CA, USA
commented

Thanks 🙏 I’ll try the patch

kristen pol’s picture

kristen pol
she/her
Primary language English
Location Santa Cruz, CA, USA
commented
Assigned: Unassigned » joshua1234511

Assigning to Joshua to test out.

kristen pol’s picture

kristen pol
she/her
Primary language English
Location Santa Cruz, CA, USA
commented
Priority: Normal » Major

Bumping priority.

joshua1234511’s picture

joshua1234511
Primary language English
Location Goa
commented
StatusFileSize
new Screenshot 2024-08-12 at 2.58.02 PM.png56.69 KB
new Screenshot 2024-08-12 at 2.58.09 PM.png72.44 KB
new Screenshot 2024-08-12 at 3.01.59 PM.png62.53 KB

Tested the patch from issue https://www.drupal.org/project/gin/issues/3242554
Patch tested from Merge Request https://git.drupalcode.org/project/gin/-/merge_requests/459

Case tested for mention issues
Case 1: when the dropdown is at the top
Issue Fixed Top

Case 2: when the dropdown is somewhere in the bottom
Issue Fixed Below
Issue Fixed Below

@kristen-pol
Not sure of the status that needs to be set to this issue, As patch needs to be applied to the https://github.com/phenaproxima/starshot-prototype.git

joshua1234511’s picture

joshua1234511
Primary language English
Location Goa
commented
Assigned: joshua1234511 » kristen pol
boulaffasae’s picture

boulaffasae commented
Status: Active » Needs review

I think we should integrate the patch for now, and follow the updates in the Gin issue.

I updated the docs: https://www.drupal.org/community-initiatives/starshot-demo-design-system...

kristen pol’s picture

kristen pol
she/her
Primary language English
Location Santa Cruz, CA, USA
commented

Yeah… was just wanting to make sure it worked and add it to dev guide 👍

kristen pol’s picture

kristen pol
she/her
Primary language English
Location Santa Cruz, CA, USA
commented
Assigned: kristen pol » joshua1234511

Joshua, if you could review the docs change, that would be great

joshua1234511’s picture

joshua1234511
Primary language English
Location Goa
commented
Assigned: joshua1234511 » kristen pol
Status: Needs review » Reviewed & tested by the community

I reviewed the document changes, updated the wording, and added a reference to the ongoing issue with the Gin theme.
Reference: https://www.drupal.org/community-initiatives/starshot-demo-design-system...

kristen pol’s picture

kristen pol
she/her
Primary language English
Location Santa Cruz, CA, USA
commented
Status: Reviewed & tested by the community » Needs review

Thanks 🙏 I’ll see if someone will review the doc steps work.

kristen pol’s picture

kristen pol
she/her
Primary language English
Location Santa Cruz, CA, USA
commented
Assigned: kristen pol » Unassigned

Unassigning from me for now.

annmarysruthy’s picture

annmarysruthy commented

Unable to review: Tried reviewing the changes in documentation https://www.drupal.org/community-initiatives/starshot-demo-design-system/sdds-development-guide. Currently unable to setup the local due to InvalidComponentException.

Error :

Drupal\Core\Render\Component\Exception\InvalidComponentException: [props.properties.link.properties] Array value found, but an object is required/n[props.properties.image.properties] Array value found, but an object is required in Drupal\Core\Theme\Component\ComponentValidator->validateDefinition() (line 121 of core/lib/Drupal/Core/Theme/Component/ComponentValidator.php).

kristen pol’s picture

kristen pol
she/her
Primary language English
Location Santa Cruz, CA, USA
commented

Created new issue:

#3469319: InvalidComponentException: [props.properties.link.properties] Array value found

kristen pol’s picture

kristen pol
she/her
Primary language English
Location Santa Cruz, CA, USA
commented
Status: Needs review » Reviewed & tested by the community

I have confirmed that using the patch steps that were added to the dev guide fixes the issue.

We should get the Gin patch added to:

https://www.drupal.org/project/drupal_cms

Leaving this RTBC until we have an issue for that.

kristen pol’s picture

kristen pol
she/her
Primary language English
Location Santa Cruz, CA, USA
commented
Status: Reviewed & tested by the community » Fixed

Since this is only needed for Paragraphs and Drupal CMS won't be using Paragraphs, let's not add this as an issue there.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.