Problem/Motivation

When running PHP CS there are more one hundred errors. They should be fixed to increase module's quality and it is one of the requests in the issue to opt to security review, see https://www.drupal.org/project/projectapplications/issues/3398888#commen....

Steps to reproduce

Run PHP CS. The easisest way is to use ddev. Follow steps to setup a drupal site with ddev: https://ddev.readthedocs.io/en/stable/users/quickstart/#drupal-drupal-10

Once it is up and running, do the following:

  • git clone it under web/module/development
  • Either run this command from your computer:

    • dev php /var/www/html/vendor/bin/phpcs --standard=Drupal web/modules/development/languagewire_translation_provider/

  • Or run connect to the PHP docker container (ddev ssh) and run this command:
          phpcs --standard=Drupal web/modules/development/languagewire_translation_provider/

Then you only have to fix errors, run php cs again and fix more errors.

Proposed resolution

Fix reported errors.

Issue fork languagewire_translation_provider-3467132

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

tunic created an issue. See original summary.

tunic’s picture

tunic
he/him
Primary language Spanish
Location Madrid
commented

Added fixes for mos of the errors thanks to automatics fixes provided by phpcbf.

To try yourself run:

phpcbf --standard=Drupal web/modules/development/languagewire_translation_provider/

sarwan_verma’s picture

sarwan_verma commented
Assigned: Unassigned » sarwan_verma

sarwan_verma opened merge request !1

sarwan_verma’s picture

sarwan_verma commented
Assigned: sarwan_verma » Unassigned
Status: Active » Needs review

Hi,

I have resolved the PHPCS issues and created MR!1.
Please review and verify.

Thanks!

lucm_lw made their first commit to this issue’s fork.

lucm_lw closed merge request !1

lucm_lw reopened merge request !1

lucm_lw’s picture

lucm_lw commented
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.