Problem/Motivation

mglaman/phpstan-drupal released version 1.2.12 (See https://github.com/mglaman/phpstan-drupal/releases/tag/1.2.12).

Looks like it became "even more betterer", since we can drop four suppressions.

Steps to reproduce

See https://git.drupalcode.org/project/drupal/-/jobs/2387856 and notice the PHP Static Analysis (phpstan) failures on the DEFAULT: Updated dependencies (PHP 8.3 MySQL 8) job for 11.x.

Proposed resolution

- Upgrade phpstan/phpstan and mglaman/phpstan-drupal to 1.2.12
- Bump versions of phpstan/phpstan and mglaman/phpstan-drupal in composer.* to latest, since the newly created baseline won't pass on any lower version.
- Create a new baseline.

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

Issue fork drupal-3467098

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

Spokje created an issue. See original summary.

spokje’s picture

spokje
Primary language Dutch
commented
Title: Bump phpstan/phpstan to latest to make daily "updated deps" QA run pass again » Bump mglaman/phpstan-drupal to latest to make daily "updated deps" QA run pass again
Issue summary: View changes

Spokje changed the visibility of the branch 3467098-bump-phpstanphpstan-to to hidden.

spokje’s picture

spokje
Primary language Dutch
commented
Title: Bump mglaman/phpstan-drupal to latest to make daily "updated deps" QA run pass again » Bump phpstan/phpstan and phpstan/phpstan and mglaman/phpstan-drupal to latest to make daily "updated deps" QA run pass again
Issue summary: View changes

Spokje opened merge request !9137

spokje’s picture

spokje
Primary language Dutch
commented
Assigned: spokje » Unassigned
Status: Active » Needs review
spokje’s picture

spokje
Primary language Dutch
commented
Title: Bump phpstan/phpstan and phpstan/phpstan and mglaman/phpstan-drupal to latest to make daily "updated deps" QA run pass again » Bump phpstan/phpstan and mglaman/phpstan-drupal to latest to make daily "updated deps" QA run pass again
smustgrave’s picture

smustgrave commented
Status: Needs review » Reviewed & tested by the community

Didn’t seem to break anything
Don’t see a reason why not

  • catch committed d4342d70 on 11.x 
    Issue #3467098 by Spokje: Bump phpstan/phpstan and mglaman/phpstan-...
catch’s picture

catch
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Fixed

Committed/pushed to 11.x, thanks!

Doesn't cherry-pick to 11.0.x but I think that's probably OK. We can update 10.4.x if-and-when we next do a general composer update probably.

catch closed merge request !9137

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.