The MailSettingsForm class defines the SETTINGS constant which is a public constant, when it is supposed to be used only by the MailSettingsForm class. It is also used only three times.

That constant can be removed, since the project is still in alpha version.

Issue fork graph_mail-3467076

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

avpaderno created an issue. See original summary.

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Issue summary: View changes

avpaderno opened merge request !32

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Status: Active » Needs review

  • avpaderno committed 32c05d70 on 1.0.x 
    Issue #3467076: Remove the MailSettingsForm::SETTINGS constant
avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.